Could not render chart without renderTo #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e controller to highcharts
Conflicts: src/directives/highchart.js
Since dropping jQuery depedency in favor of angular.extend() it was not possible to render a chart without specifying manually the renderTo property. This was due to the fact that angular.extend() is not recursive (whereas jQuery was). To avoid adding depedency we merge manually the few properties.
rootux
added a commit
that referenced
this pull request
Feb 28, 2014
Could not render chart without renderTo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #8, jQuery was replaced by angular.extend(). But those functions are not equals and it broke chart rendering when the renderTo property was not set manually.
This pull request use a "manual" merge to avoid adding dependencies.