Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dplR::latexify to translate names to latex #109

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Use dplR::latexify to translate names to latex #109

wants to merge 20 commits into from

Commits on Sep 23, 2024

  1. Fix toBiblatex when BibEntry has Japanese author names 

    * tools::encoded_text_to_latex(text, UTF-8) can fail when text contains
Japanese characters, replacing valid text with questions marks
* Add escape hatch to return origin/unformatted/unescaped text if this
occurs
* Closes #106
    @mwmclean
    mwmclean committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    7073a05 View commit details
    Browse the repository at this point in the history

  2. Add tests for last commit

    @mwmclean
    mwmclean committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5ca9858 View commit details
    Browse the repository at this point in the history

  3. Add argument to toBiblatex and toBibtex 

    * Add argument encoded.names.to.latex to toBibTeX and toBibLaTeX to
toggle whether tools::encoded_text_to_latex is called on name list fields
* Closes #105
    @mwmclean
    mwmclean committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    02f43d2 View commit details
    Browse the repository at this point in the history

  4. Fix package documentation for latest roxygen2 

    * c.f. https://r-pkgs.org/man.html#sec-man-package-doc
    @mwmclean
    mwmclean committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2cf2a96 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Remove unused code from unit test; add newline

    @mwmclean
    mwmclean committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    139049b View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Fix 7073a if names require braces 

    * See toBibtex.person, braces seem necessary if no family name is detected
* Addresses #106
    @mwmclean
    mwmclean committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    48f1e74 View commit details
    Browse the repository at this point in the history

  2. Use dplR::latexify to translate names to latex 

    * Switch from tools::encoded_text_to_latex to dplR::latexify in
toBiblatex and toBibtex to fix translation of accented i characters
to latex
* Fixes #102, #106
    @mwmclean
    mwmclean committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    766fd00 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Update unit test

    @mwmclean
    mwmclean committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a249a10 View commit details
    Browse the repository at this point in the history

  2. Update URL for ReadPDFs unit test

    @mwmclean
    mwmclean committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d6628b3 View commit details
    Browse the repository at this point in the history

  3. Update additional unit test for latexify

    @mwmclean
    mwmclean committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d546b3b View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Trigger tests

    @mwmclean
    mwmclean committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    0e63d1a View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Trigger tests 

    Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    97d56f6 View commit details
    Browse the repository at this point in the history

  2. Trigger tests again 

    Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    f0007ba View commit details
    Browse the repository at this point in the history

  3. Always use pdfinfo to determine page counts in ReadPDFs 

    * When use.metadata is FALSE, pdfinfo will now still be called to determine
number of pages in the document
* This avoids a message from pdftotext in the case of 1-page PDFs

Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7110762 View commit details
    Browse the repository at this point in the history

  4. Refactor ReadPDFs tests to make skip reason clearer 

    Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c8e4849 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Fix check NOTE/update documentation 

    Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    4c4b84c View commit details
    Browse the repository at this point in the history

  2. Remove appveyor 

    Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    c3c25ba View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Add modified version of latexify to package 

    * dplR::latexify escapes braces and adds tildes for whitespace
when this is not desirable for biblatex/bibtex
* Hence include modified copy of latexify in the package and add
dplR maintainer as contributor in DESCRIPTION
    @mwmclean
    mwmclean committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    f70a1db View commit details
    Browse the repository at this point in the history

  2. Add stringi dependency to DESCRIPTION

    @mwmclean
    mwmclean committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    de8e92b View commit details
    Browse the repository at this point in the history

  3. Import R.utils::captureOutput 

    Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    80b5581 View commit details
    Browse the repository at this point in the history