Handle remote deps #382
Merged
Handle remote deps #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nality unaffected
if there was a git_pkgs but not a cran_pkgs archive, the previous code would fail.
Fix handle remote deps
|
@mihem where you able to build an env with your package scMisc? I see it also comes with a remote dep |
|
Well I used my CSFAtlasTool which worked great, but there was an error when calling the remote dependency package |
…kages Fix double installation remote packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows rix to handle packages with remote dependencies. For now, only remote that are hosted on Github are correctly handled, and only if they are written as
Remotes: r-lib/testthatin the main package's description file. Remote dependencies of remote dependencies are also handled.TODO:
r-lib/testthat@c67018fa4970fyi @mihem