Skip to content

Commit

Permalink
updated all vignettes, updated news, cran comments, and bumped to nex…
Browse files Browse the repository at this point in the history
…t cran release version
  • Loading branch information
sckott committed Aug 30, 2016
1 parent 8586f7f commit 699df9c
Show file tree
Hide file tree
Showing 35 changed files with 627 additions and 424 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@ README.Rmd
vignettes/figure
^CONDUCT\.md$
user_test_cases/
^cran-comments\.md$
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Description: Client for many 'NOAA' data sources including the 'NCDC' climate
for 'NOAA' sea ice data, the 'NOAA' severe weather inventory, 'NOAA' Historical
Observing 'Metadata' Repository ('HOMR') data, 'NOAA' storm data via 'IBTrACS',
tornado data via the 'NOAA' storm prediction center, and more.
Version: 0.5.9.9140
Version: 0.6.0
License: MIT + file LICENSE
Encoding: UTF-8
Authors@R: c(
Expand Down
1 change: 0 additions & 1 deletion NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ importFrom(dplyr,bind_rows)
importFrom(dplyr,contains)
importFrom(dplyr,filter)
importFrom(dplyr,mutate)
importFrom(dplyr,rbind_all)
importFrom(dplyr,rename)
importFrom(dplyr,select)
importFrom(dplyr,tbl_df)
Expand Down
81 changes: 62 additions & 19 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,46 @@
rnoaa 0.6.0
===============

### NEW FEATURES

* A large PR was merged with a suite of functions. Most functions added
a prefixed with `meteo_*`, and are meant to find weather monitors near
locations (`meteo_nearby_stations`), find all monitors within a radius
of a location (`meteo_distance`), calculate the distances between a
location and all available stations (`meteo_process_geographic_data`),
calculate the distance between two locations (`meteo_spherical_distance`),
pull GHCND weather data for multiple weather monitors (`meteo_pull_monitors`),
create a tidy GHCND dataset from a single monitor (`meteo_tidy_ghcnd`),
and determine the "coverage" for a station data frame (`meteo_coverage()`).
In addition, `vis_miss()` added to visualize missingness in a data.frame. See
the [PR diff against master](https://github.com/ropensci/rnoaa/pull/159/files)
for all the changes. (#159) Thanks a ton to @geanders _et al_. (@hrbrmstr,
@masalmon, @jdunic, @njtierney, @leighseverson, @RyanGan, @mandilin, @jferreri,
@cpatrizio88, @ryan-hicks, @Ewen2015, @mgutilla, @hakessler, @rodlammers)

### MINOR IMPROVEMENTS

* `isd_stations_search()` changed internal structure. We replaced
usage of `geojsonio` and `lawn` for faster `dplyr::filter` for
bbox inputs, and `meteo_distance()` for `lat/long/radius` inputs
. This speeds up this function significantly. Thanks to @lukas-rokka
(#157)
* `isd_stations_search()` and `isd_stations()` now return
tibble's instead of data.frame's
* Removed cached ISD stations dataset within package to reduce
package size. Only change is now that on first use of the function
the user has to download the entire thing, but on subsquent
uses it will pull from the cached version on the users machine.
`isd_stations_search()` now caches using `rappdirs` (#161)
* Convert all `is()` uses to `inherits()`

### BUG FIXES

* Fixed `seaiceeurls()` function that's used to generate urls for
the `seaice()` function - due to change in NOAA urls (#160)
* Fix to function `ghncd_split_vars()` to not fail on `dplyr::contains`
call (#156) thanks @lawinslow !

rnoaa 0.5.6
===============

Expand All @@ -6,24 +49,24 @@ rnoaa 0.5.6
* Fixes for new `httr` version to call encoding explicitly (#135)
* Fix to broken link for reference to source code used in `gefs` functions (#121)
* Speed ups implemented for the `isd()` function - it's a time consuming task
as we have to parse a nasty string of characters line by line - more speed
as we have to parse a nasty string of characters line by line - more speed
ups to come in future versions (#146)
* Replace `dplyr::rbind_all()` with `dplyr::bind_rows()` as the former is
being deprecated (#152)

### BUG FIXES

* Fix for `isd()` function - was failing on some station names that had
* Fix for `isd()` function - was failing on some station names that had
leading zeros. (#136)
* Fix for `ncdc_stations()` - used to allow more than one station id to
be passed in, but internally only handled one. This is a restriction
due to the NOAA NCDC API. Documentation now shows an example of how
* Fix for `ncdc_stations()` - used to allow more than one station id to
be passed in, but internally only handled one. This is a restriction
due to the NOAA NCDC API. Documentation now shows an example of how
to deal with many station ids (#138)
* Fixes to the suite of `ncdc_*()` functions to allow multiple inputs
to those parameters where allowed (#139)
* Fixed bug in `ncdc_plot()` due to new `ggplot2` version (#153)
* Fixed bugs in `argo()` functions: a) with new `httr`, box input of a vector
no longer works, now manually make a character vector; b) errant file param
* Fixed bugs in `argo()` functions: a) with new `httr`, box input of a vector
no longer works, now manually make a character vector; b) errant file param
being passed into the http request, removed (#155)

rnoaa 0.5.2
Expand All @@ -33,7 +76,7 @@ rnoaa 0.5.2

* New data source added: ARGO buoy data. See functions starting with `argo()` (#123)
for more, see http://www.argo.ucsd.edu/
* New data source added: CO-OPS tide and current data. See function `coops_search()`
* New data source added: CO-OPS tide and current data. See function `coops_search()`
(#111) for idea from @fmichonneau (#124) for implementing @jsta See http://co-ops.nos.noaa.gov/api/
also (#126) (#128)

Expand All @@ -48,35 +91,35 @@ rnoaa 0.5.0

### NEW FEATURES

* New data source added: NOAA Global Ensemble Forecast System (GEFS) data.
See functions `gefs()`, `gefs_dimension_values()`, `gefs_dimensions()`, `gefs_latitudes()`,
`gefs_longitudes()`, and `gefs_variables()` (#106) (#119) thanks @potterzot - he's
* New data source added: NOAA Global Ensemble Forecast System (GEFS) data.
See functions `gefs()`, `gefs_dimension_values()`, `gefs_dimensions()`, `gefs_latitudes()`,
`gefs_longitudes()`, and `gefs_variables()` (#106) (#119) thanks @potterzot - he's
now an author too
* New data source added: NOAA Extended Reconstructed Sea Surface Temperature
* New data source added: NOAA Extended Reconstructed Sea Surface Temperature
(ERSST) data. See function `ersst()` (#96)
* New function `isd_stations()` to get ISD station data.
* Added code of conduct to code repository

### MINOR IMPROVEMENTS

* Swapped `ncdf` package for `ncdf4` package. Windows binaries weren't
* Swapped `ncdf` package for `ncdf4` package. Windows binaries weren't
availiable for `ncdf4` prior to now. (#117)
* Proper license info added for javascript modules used inside the
package (#116)
* Improvements to `isd()` function to do transformations of certain
* Improvements to `isd()` function to do transformations of certain
variables to give back data that makes more sense (#115)
* `leaflet`, `geojsonio`, and `lawn` added in Suggests, used in a few
* `leaflet`, `geojsonio`, and `lawn` added in Suggests, used in a few
functions.
* Note added to `swdi()` function man page that the `nldn` dataset is
* Note added to `swdi()` function man page that the `nldn` dataset is
available to military users only (#107)

### BUG FIXES

* Fix to `buoy()` function to accept character class inputs for the
`buoyid` parameter. the error occurred because matching was not
* Fix to `buoy()` function to accept character class inputs for the
`buoyid` parameter. the error occurred because matching was not
case-insensitive, now works regardless of case (#118)
* Fixes for new `ggplot2` version (#113)
* Built in `GET` request retries for `ghncd` functions as
* Built in `GET` request retries for `ghncd` functions as
some URLs fail unpredictably (#110)

rnoaa 0.4.2
Expand Down
2 changes: 1 addition & 1 deletion R/isd_stations_search.R
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,6 @@ isd_stations_search <- function(lat = NULL, lon = NULL, radius = NULL, bbox = NU
filter(stations, lat >= bbox[2] & lat <= bbox[4], lon >= bbox[1] & lon <= bbox[3])
} else {
stations <- rename(stations, latitude = lat, longitude = lon)
meteo_distance(stations, lat, lon, radius = radius)
meteo_distance(stations, lat = lat, long = lon, radius = radius)
}
}
3 changes: 1 addition & 2 deletions R/ncdc_plot.r
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ ncdc_plot.ncdc_data <- function(..., breaks = NULL, dateformat='%d/%m/%y') {
}

#' @export
ncdc_plot.default <- function(..., breaks = NULL, dateformat='%d/%m/%y') {
ncdc_plot.default <- function(..., breaks = NULL, dateformat = '%d/%m/%y') {
stop("No method for ", class(list(...)[[1]]), call. = FALSE)
}

Expand All @@ -77,7 +77,6 @@ plot_template <- function(df, breaks, dateformat) {
)
if (!is.null(breaks)) {
c(tt, scale_x_date(date_breaks = breaks, date_labels = dateformat))

} else {
tt
}
Expand Down
2 changes: 1 addition & 1 deletion R/rnoaa-package.r
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
#' @importFrom tidyr gather
#' @importFrom rappdirs user_cache_dir
#' @importFrom gridExtra grid.arrange
#' @importFrom dplyr %>% rbind_all select mutate rename tbl_df filter bind_rows
#' @importFrom dplyr %>% select mutate rename tbl_df filter bind_rows
#' as_data_frame contains
#' @importFrom tibble as_data_frame
#' @importFrom scales comma
Expand Down
30 changes: 25 additions & 5 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,27 @@
R CMD CHECK passed on my local OS X install on R 3.3.0 and R development
version, Ubuntu running on Travis-CI, and Win builder.
## Test environments

This submission makes some fixes for new versions of dependencies,
and fixes a series of bugs.
* local OS X install, R 3.3.1
* ubuntu 12.04 (on travis-ci), R 3.3.1
* win-builder (devel and release)

Thanks! Scott Chamberlain
## R CMD check results

0 errors | 0 warnings | 1 note

License components with restrictions and base license permitting such:
MIT + file LICENSE
File 'LICENSE':
YEAR: 2016
COPYRIGHT HOLDER: Scott Chamberlain

## Reverse dependencies

There are no reverse dependencies.

-----

This release adds some new functions, improves performance
in a function, fixes a few bugs.

Thanks!
Scott Chamberlain
96 changes: 48 additions & 48 deletions inst/vign/buoy_vignette.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,18 +73,18 @@ buoy(dataset = 'cwind', buoyid = 46085)
#> Dimensions (rows/cols): [33486 X 5]
#> 2 variables: [wind_dir, wind_spd]
#>
#> time latitude longitude wind_dir wind_spd
#> 1 2007-05-05T02:00:00Z 55.855 -142.559 331 2.8
#> 2 2007-05-05T02:10:00Z 55.855 -142.559 328 2.6
#> 3 2007-05-05T02:20:00Z 55.855 -142.559 329 2.2
#> 4 2007-05-05T02:30:00Z 55.855 -142.559 356 2.1
#> 5 2007-05-05T02:40:00Z 55.855 -142.559 360 1.5
#> 6 2007-05-05T02:50:00Z 55.855 -142.559 10 1.9
#> 7 2007-05-05T03:00:00Z 55.855 -142.559 10 2.2
#> 8 2007-05-05T03:10:00Z 55.855 -142.559 14 2.2
#> 9 2007-05-05T03:20:00Z 55.855 -142.559 16 2.1
#> 10 2007-05-05T03:30:00Z 55.855 -142.559 22 1.6
#> .. ... ... ... ... ...
#> time lat lon wind_dir wind_spd
#> 1 2007-05-05T02:00:00Z 55.855 -142.559 331 2.8
#> 2 2007-05-05T02:10:00Z 55.855 -142.559 328 2.6
#> 3 2007-05-05T02:20:00Z 55.855 -142.559 329 2.2
#> 4 2007-05-05T02:30:00Z 55.855 -142.559 356 2.1
#> 5 2007-05-05T02:40:00Z 55.855 -142.559 360 1.5
#> 6 2007-05-05T02:50:00Z 55.855 -142.559 10 1.9
#> 7 2007-05-05T03:00:00Z 55.855 -142.559 10 2.2
#> 8 2007-05-05T03:10:00Z 55.855 -142.559 14 2.2
#> 9 2007-05-05T03:20:00Z 55.855 -142.559 16 2.1
#> 10 2007-05-05T03:30:00Z 55.855 -142.559 22 1.6
#> .. ... ... ... ... ...
```

Including year
Expand All @@ -98,18 +98,18 @@ buoy(dataset = 'cwind', buoyid = 41001, year = 1999)
#> Dimensions (rows/cols): [52554 X 5]
#> 2 variables: [wind_dir, wind_spd]
#>
#> time latitude longitude wind_dir wind_spd
#> 1 1999-01-01T00:00:00Z 34.68 -72.66 272 11.7
#> 2 1999-01-01T00:10:00Z 34.68 -72.66 260 11.0
#> 3 1999-01-01T00:20:00Z 34.68 -72.66 249 8.7
#> 4 1999-01-01T00:30:00Z 34.68 -72.66 247 8.4
#> 5 1999-01-01T00:40:00Z 34.68 -72.66 240 7.1
#> 6 1999-01-01T00:50:00Z 34.68 -72.66 242 7.9
#> 7 1999-01-01T01:00:00Z 34.68 -72.66 246 8.3
#> 8 1999-01-01T01:10:00Z 34.68 -72.66 297 10.9
#> 9 1999-01-01T01:20:00Z 34.68 -72.66 299 11.3
#> 10 1999-01-01T01:30:00Z 34.68 -72.66 299 11.1
#> .. ... ... ... ... ...
#> time lat lon wind_dir wind_spd
#> 1 1999-01-01T00:00:00Z 34.68 -72.66 272 11.7
#> 2 1999-01-01T00:10:00Z 34.68 -72.66 260 11.0
#> 3 1999-01-01T00:20:00Z 34.68 -72.66 249 8.7
#> 4 1999-01-01T00:30:00Z 34.68 -72.66 247 8.4
#> 5 1999-01-01T00:40:00Z 34.68 -72.66 240 7.1
#> 6 1999-01-01T00:50:00Z 34.68 -72.66 242 7.9
#> 7 1999-01-01T01:00:00Z 34.68 -72.66 246 8.3
#> 8 1999-01-01T01:10:00Z 34.68 -72.66 297 10.9
#> 9 1999-01-01T01:20:00Z 34.68 -72.66 299 11.3
#> 10 1999-01-01T01:30:00Z 34.68 -72.66 299 11.1
#> .. ... ... ... ... ...
```

Including year and datatype
Expand All @@ -123,18 +123,18 @@ buoy(dataset = 'cwind', buoyid = 41001, year = 2008, datatype = "cc")
#> Dimensions (rows/cols): [1585 X 5]
#> 2 variables: [wind_dir, wind_spd]
#>
#> time latitude longitude wind_dir wind_spd
#> 1 2008-05-28T16:00:00Z 34.704 -72.734 230 8.6
#> 2 2008-05-28T16:10:00Z 34.704 -72.734 230 8.7
#> 3 2008-05-28T16:20:00Z 34.704 -72.734 229 8.5
#> 4 2008-05-28T16:30:00Z 34.704 -72.734 231 8.8
#> 5 2008-05-28T16:40:00Z 34.704 -72.734 236 8.5
#> 6 2008-05-28T16:50:00Z 34.704 -72.734 235 8.9
#> 7 2008-05-28T17:00:00Z 34.704 -72.734 233 8.2
#> 8 2008-05-28T17:10:00Z 34.704 -72.734 233 8.2
#> 9 2008-05-28T17:20:00Z 34.704 -72.734 231 8.3
#> 10 2008-05-28T17:30:00Z 34.704 -72.734 232 7.8
#> .. ... ... ... ... ...
#> time lat lon wind_dir wind_spd
#> 1 2008-05-28T16:00:00Z 34.704 -72.734 230 8.6
#> 2 2008-05-28T16:10:00Z 34.704 -72.734 230 8.7
#> 3 2008-05-28T16:20:00Z 34.704 -72.734 229 8.5
#> 4 2008-05-28T16:30:00Z 34.704 -72.734 231 8.8
#> 5 2008-05-28T16:40:00Z 34.704 -72.734 236 8.5
#> 6 2008-05-28T16:50:00Z 34.704 -72.734 235 8.9
#> 7 2008-05-28T17:00:00Z 34.704 -72.734 233 8.2
#> 8 2008-05-28T17:10:00Z 34.704 -72.734 233 8.2
#> 9 2008-05-28T17:20:00Z 34.704 -72.734 231 8.3
#> 10 2008-05-28T17:30:00Z 34.704 -72.734 232 7.8
#> .. ... ... ... ... ...
```

Including just datatype
Expand All @@ -148,16 +148,16 @@ buoy(dataset = 'cwind', buoyid = 41001, datatype = "cc")
#> Dimensions (rows/cols): [1585 X 5]
#> 2 variables: [wind_dir, wind_spd]
#>
#> time latitude longitude wind_dir wind_spd
#> 1 2008-05-28T16:00:00Z 34.704 -72.734 230 8.6
#> 2 2008-05-28T16:10:00Z 34.704 -72.734 230 8.7
#> 3 2008-05-28T16:20:00Z 34.704 -72.734 229 8.5
#> 4 2008-05-28T16:30:00Z 34.704 -72.734 231 8.8
#> 5 2008-05-28T16:40:00Z 34.704 -72.734 236 8.5
#> 6 2008-05-28T16:50:00Z 34.704 -72.734 235 8.9
#> 7 2008-05-28T17:00:00Z 34.704 -72.734 233 8.2
#> 8 2008-05-28T17:10:00Z 34.704 -72.734 233 8.2
#> 9 2008-05-28T17:20:00Z 34.704 -72.734 231 8.3
#> 10 2008-05-28T17:30:00Z 34.704 -72.734 232 7.8
#> .. ... ... ... ... ...
#> time lat lon wind_dir wind_spd
#> 1 2008-05-28T16:00:00Z 34.704 -72.734 230 8.6
#> 2 2008-05-28T16:10:00Z 34.704 -72.734 230 8.7
#> 3 2008-05-28T16:20:00Z 34.704 -72.734 229 8.5
#> 4 2008-05-28T16:30:00Z 34.704 -72.734 231 8.8
#> 5 2008-05-28T16:40:00Z 34.704 -72.734 236 8.5
#> 6 2008-05-28T16:50:00Z 34.704 -72.734 235 8.9
#> 7 2008-05-28T17:00:00Z 34.704 -72.734 233 8.2
#> 8 2008-05-28T17:10:00Z 34.704 -72.734 233 8.2
#> 9 2008-05-28T17:20:00Z 34.704 -72.734 231 8.3
#> 10 2008-05-28T17:30:00Z 34.704 -72.734 232 7.8
#> .. ... ... ... ... ...
```
Binary file modified inst/vign/figure/seaice1-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified inst/vign/figure/seaice2-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified inst/vign/figure/unnamed-chunk-3-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified inst/vign/figure/unnamed-chunk-4-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified inst/vign/figure/unnamed-chunk-7-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified inst/vign/figure/unnamed-chunk-8-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit 699df9c

Please sign in to comment.