Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release tasks #210

Merged
merged 7 commits into from
Oct 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@
Thumbs.db
Rplots.pdf
revdep/

/.quarto/
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: tidyhydat
Title: Extract and Tidy Canadian 'Hydrometric' Data
Version: 0.6.1.9000
Version: 0.7.0
Authors@R: c(person("Sam", "Albers", email = "[email protected]", role = c("aut", "cre"),
comment = c(ORCID = "0000-0002-9270-7884")),
person("David", "Hutchinson", email = "[email protected]", role = "ctb"),
Expand All @@ -20,7 +20,7 @@ License: Apache License (== 2.0) | file LICENSE
URL: https://docs.ropensci.org/tidyhydat/, https://github.com/ropensci/tidyhydat/
BugReports: https://github.com/ropensci/tidyhydat/issues/
Depends:
R (>= 4.0.0)
R (>= 4.2.0)
Imports:
cli (>= 1.0.0),
crayon (>= 1.3.4),
Expand Down
4 changes: 2 additions & 2 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# tidyhydat 0.6.1.9000
- bump minimum R version to 4.0.0
# tidyhydat 0.7.0
- bump minimum R version to 4.2.0
- dropped httr in favour of httr2
- fix bug where `download_hydat()` fails if `tempdir()` is on a different device than `hydat_path` (@mpdavison, #192)
- fix bug where `download_hydat()` wasn't checking alternative paths for success (@Travis-Simmons)
Expand Down
2 changes: 1 addition & 1 deletion README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ knitr::opts_chunk$set(


<!-- badges: start -->
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/license/apache-2-0/)ß
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/license/apache-2-0)
[![R build status](https://github.com/ropensci/tidyhydat/workflows/R-CMD-check/badge.svg)](https://github.com/ropensci/tidyhydat/actions)

[![CRAN\_Status\_Badge](https://www.r-pkg.org/badges/version/tidyhydat)](https://cran.r-project.org/package=tidyhydat) [![CRAN Downloads](https://cranlogs.r-pkg.org/badges/tidyhydat?color=brightgreen)](https://CRAN.R-project.org/package=tidyhydat) [![cran checks](https://badges.cranchecks.info/worst/tidyhydat.svg)](https://cran.r-project.org/web/checks/check_results_tidyhydat.html) [![r-universe](https://ropensci.r-universe.dev/badges/tidyhydat)](https://ropensci.r-universe.dev/builds)
Expand Down
71 changes: 32 additions & 39 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<!-- badges: start -->

[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/license/apache-2-0/)ß
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/license/apache-2-0)
[![R build
status](https://github.com/ropensci/tidyhydat/workflows/R-CMD-check/badge.svg)](https://github.com/ropensci/tidyhydat/actions)

Expand Down Expand Up @@ -84,24 +84,22 @@ the same conventions discussed above. Using `realtime_dd()` we can
easily select specific stations by supplying a station of interest:

realtime_dd(station_number = "08MF005")
#> Queried on: 2024-01-09 05:08:33.18974 (UTC)
#> Date range: 2023-12-10 to 2024-01-09
#> # A tibble: 10,972 × 8
#> STATION_NUMBER PROV_TERR_STATE_LOC Date
#> <chr> <chr> <dttm>
#> 1 08MF005 BC 2023-12-10 08:00:00
#> 2 08MF005 BC 2023-12-10 08:05:00
#> 3 08MF005 BC 2023-12-10 08:10:00
#> 4 08MF005 BC 2023-12-10 08:15:00
#> 5 08MF005 BC 2023-12-10 08:20:00
#> 6 08MF005 BC 2023-12-10 08:25:00
#> 7 08MF005 BC 2023-12-10 08:30:00
#> 8 08MF005 BC 2023-12-10 08:35:00
#> 9 08MF005 BC 2023-12-10 08:40:00
#> 10 08MF005 BC 2023-12-10 08:45:00
#> # ℹ 10,962 more rows
#> # ℹ 5 more variables: Parameter <chr>, Value <dbl>,
#> # Grade <chr>, Symbol <chr>, Code <chr>
#> Queried on: 2024-10-04 21:22:54.830085 (UTC)
#> Date range: 2024-09-04 to 2024-10-04
#> # A tibble: 17,574 × 8
#> STATION_NUMBER PROV_TERR_STATE_LOC Date Parameter Value Grade Symbol Code
#> <chr> <chr> <dttm> <chr> <dbl> <chr> <chr> <chr>
#> 1 08MF005 BC 2024-09-04 08:00:00 Flow 1830 <NA> <NA> 1
#> 2 08MF005 BC 2024-09-04 08:05:00 Flow 1830 <NA> <NA> 1
#> 3 08MF005 BC 2024-09-04 08:10:00 Flow 1830 <NA> <NA> 1
#> 4 08MF005 BC 2024-09-04 08:15:00 Flow 1840 <NA> <NA> 1
#> 5 08MF005 BC 2024-09-04 08:20:00 Flow 1840 <NA> <NA> 1
#> 6 08MF005 BC 2024-09-04 08:25:00 Flow 1830 <NA> <NA> 1
#> 7 08MF005 BC 2024-09-04 08:30:00 Flow 1830 <NA> <NA> 1
#> 8 08MF005 BC 2024-09-04 08:35:00 Flow 1830 <NA> <NA> 1
#> 9 08MF005 BC 2024-09-04 08:40:00 Flow 1830 <NA> <NA> 1
#> 10 08MF005 BC 2024-09-04 08:45:00 Flow 1830 <NA> <NA> 1
#> # ℹ 17,564 more rows

Or we can use `realtime_ws`:

Expand All @@ -113,22 +111,20 @@ Or we can use `realtime_ws`:
)
#> All station successfully retrieved
#> All parameters successfully retrieved
#> # A tibble: 1,323 × 10
#> STATION_NUMBER Date Name_En Value Unit
#> <chr> <dttm> <chr> <dbl> <chr>
#> 1 08MF005 2023-12-25 00:00:00 Water tem… 5.14 °C
#> 2 08MF005 2023-12-25 01:00:00 Water tem… 5.12 °C
#> 3 08MF005 2023-12-25 02:00:00 Water tem… 5.11 °C
#> 4 08MF005 2023-12-25 03:00:00 Water tem… 5.1 °C
#> 5 08MF005 2023-12-25 04:00:00 Water tem… 5.1 °C
#> 6 08MF005 2023-12-25 05:00:00 Water tem… 5.07 °C
#> 7 08MF005 2023-12-25 06:00:00 Water tem… 5.06 °C
#> 8 08MF005 2023-12-25 07:00:00 Water tem… 5.04 °C
#> 9 08MF005 2023-12-25 08:00:00 Water tem… 5.02 °C
#> 10 08MF005 2023-12-25 09:00:00 Water tem… 5 °C
#> # ℹ 1,313 more rows
#> # ℹ 5 more variables: Grade <chr>, Symbol <chr>,
#> # Approval <chr>, Parameter <dbl>, Code <chr>
#> # A tibble: 4,632 × 10
#> STATION_NUMBER Date Name_En Value Unit Grade Symbol Approval Parameter Code
#> <chr> <dttm> <chr> <dbl> <chr> <chr> <chr> <chr> <dbl> <chr>
#> 1 08MF005 2024-09-20 00:00:00 Water temperature 17.0 °C -1 <NA> Provisional/Provisoire 5 TW
#> 2 08MF005 2024-09-20 01:00:00 Water temperature 17.0 °C -1 <NA> Provisional/Provisoire 5 TW
#> 3 08MF005 2024-09-20 02:00:00 Water temperature 17.1 °C -1 <NA> Provisional/Provisoire 5 TW
#> 4 08MF005 2024-09-20 03:00:00 Water temperature 17.1 °C -1 <NA> Provisional/Provisoire 5 TW
#> 5 08MF005 2024-09-20 04:00:00 Water temperature 17.1 °C -1 <NA> Provisional/Provisoire 5 TW
#> 6 08MF005 2024-09-20 05:00:00 Water temperature 17.1 °C -1 <NA> Provisional/Provisoire 5 TW
#> 7 08MF005 2024-09-20 06:00:00 Water temperature 17.1 °C -1 <NA> Provisional/Provisoire 5 TW
#> 8 08MF005 2024-09-20 07:00:00 Water temperature 17.1 °C -1 <NA> Provisional/Provisoire 5 TW
#> 9 08MF005 2024-09-20 08:00:00 Water temperature 17.1 °C -1 <NA> Provisional/Provisoire 5 TW
#> 10 08MF005 2024-09-20 09:00:00 Water temperature 17.1 °C -1 <NA> Provisional/Provisoire 5 TW
#> # ℹ 4,622 more rows

## Compare realtime\_ws and realtime\_dd

Expand Down Expand Up @@ -193,10 +189,7 @@ Get citation information for `tidyhydat` in R by running:

To cite package 'tidyhydat' in publications use:

Albers S (2017). "tidyhydat: Extract and Tidy
Canadian Hydrometric Data." _The Journal of Open
Source Software_, *2*(20). doi:10.21105/joss.00511
<https://doi.org/10.21105/joss.00511>,
Albers S (2017). "tidyhydat: Extract and Tidy Canadian Hydrometric Data." _The Journal of Open Source Software_, *2*(20). doi:10.21105/joss.00511 <https://doi.org/10.21105/joss.00511>,
<http://dx.doi.org/10.21105/joss.00511>.

A BibTeX entry for LaTeX users is
Expand Down
28 changes: 28 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,31 @@
tidyhydat 0.7.0
=========================

There were zero WARNINGS and zero ERRORS.

## NEWS
- bump minimum R version to 4.2.0
- dropped httr in favour of httr2
- fix bug where `download_hydat()` fails if `tempdir()` is on a different device than `hydat_path` (@mpdavison, #192)
- fix bug where `download_hydat()` wasn't checking alternative paths for success (@Travis-Simmons)

## Test environments
* win-builder (via `devtools::check_win_devel()` and `devtools::check_win_release()`)
* local macOS, R 4.3.1 (via R CMD check --as-cran)
* ubuntu-20.04, r: 'release' (github actions)
* ubuntu-20.04, r: 'devel' (github actions)
* macOS, r: 'release' (github actions)
* windows, r: 'release' (github actions)
* Fedora Linux, R-devel, clang, gfortran - r-hub
* Debian Linux, R-release, GCC (debian-gcc-release) - r-hub
* Windows Server 2008 R2 SP1, R-devel, 32/64 bit - r-hub
## revdepcheck results

We checked 3 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

* We saw 0 new problems
* We failed to check 0 packages

tidyhydat 0.6.1
=========================

Expand Down
Loading
Loading