-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add get_protected() #111
add get_protected() #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 👏
Now I'll go try it out in babeldown and report back!
My report is #113 |
Co-authored-by: Maëlle Salmon <[email protected]>
This works for both carpentries/pegboard@1d1be7b and ropensci-review-tools/babeldown#70, so I will go ahead and merge this so that the maintainers of babeldown and pegboard can move forward. |
Thank you!! |
This adds the
get_protected()
function, which provides a way to access the protected nodes that are labelled "@asis" or "@curly". See #109 for motivation. It will allow me to implement #107 without too much damage.It also uses attributes to distinguish between protections.
I think this would help with {babeldown} by providing explicit accessors so that these lines of code will turn into:
Here's an example of what it returns:
Created on 2024-05-09 with reprex v2.1.0