add recursive function to find currency dollars #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not work because it breaks the postfix dollar treatment
This makes it easier to re-test once we've transformed
1. If there are no headless math, then just return because it's all money 2. If there is are more endless than headless, toss the money and keep going Ultimately, if there is an imbalance (even after 2), then an error should be thrown
The tests for the postfix dollars have now changed because we are sort of loosening the restrictions, which ultimately is a good thing because people will run into fewer errors when protecting math.
This simplifies the function to three conditionals from four and clearly labels the condidtions, starting with the exit condition.
maelle
reviewed
Nov 12, 2024
| @@ -129,7 +129,7 @@ protect_inline_math <- function(body, ns) { | |||
| } | |||
|
|
|||
| # protect math that is broken across lines or markdown elements | |||
| if (length(bmath)) { | |||
There was a problem hiding this comment.
maybe use an explaining variable although that is already clear
| le <- length(bmath[endless]) | ||
| lh <- length(bmath[headless]) | ||
| # 2024-10-10: if the number of headless tags is zero, then we are dealing | ||
| # with currency. See issue #121 | ||
| if (lh == 0) { | ||
| return(copy_xml(body)) | ||
| } | ||
| # 2024-10-15: if the number of headless tags is _less_ than the number of |
There was a problem hiding this comment.
Suggested change
| # 2024-10-15: if the number of headless tags is _less_ than the number of | |
| # 2024-10-15: if the number of startless tags is _less_ than the number of |
There was a problem hiding this comment.
the variable is actually headless, but I wonder if it might be confusing
| } | ||
| # return the result and iterate over the rest of the vector | ||
| return(c(result, toss_broken_teeth(endless[idx], headless[idx]))) | ||
| } |
There was a problem hiding this comment.
should we use devtag https://github.com/moodymudskipper/devtag
and have examples
| tinkr::yarn$new(ex)$protect_math()$get_protected() | ||
| ``` | ||
| 2. Postfix dollar signs (e.g. using BASIC code demostrations) should be | ||
| protected with backtics, or it will cause an error. |
There was a problem hiding this comment.
Suggested change
| protected with backtics, or it will cause an error. | |
| protected with backticks, or it will cause an error. |
| ex <- textConnection("$5 for _any_ $\\pi$") | ||
| tinkr::yarn$new(ex)$protect_math()$get_protected() | ||
| ``` | ||
| 2. Postfix dollar signs (e.g. using BASIC code demostrations) should be |
There was a problem hiding this comment.
Suggested change
| 2. Postfix dollar signs (e.g. using BASIC code demostrations) should be | |
| 2. Postfix dollar signs (e.g. using BASIC code demonstrations) should be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a stronger solution to #121.
It does a second check to see if there are more opening dollar signs than
closing and then passes those through a function that walks the list of broken
math elements and detects the opening elements that aren't paired with closing
elements (by confirming that the pairs are adjacent). The opening elements that
aren't paired are excluded from the list and then if the list is still not
balanced an error is thrown.