ts_ggplot: pass symbols, not strings (fix #223)

ropensci · Sep 14, 2023 · d8bf6dc · d8bf6dc · p-wegmueller · Sep 20, 2023
1 parent abbdcfc
commit d8bf6dc
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: tsbox
 Type: Package
 Title: Class-Agnostic Time Series
-Version: 0.4.1
+Version: 0.4.1.9001
 Authors@R: c(
     person("Christoph", "Sax", email = "[email protected]", role = c("aut", "cre"), comment = c(ORCID = "0000-0002-7192-7044")),
     person("Cathy", "Chamberlin", role = c("rev")),

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,8 @@
+# tsbox 0.4.1.9001
+
+- ts_ggplot: pass symbols, not strings (fix #223)
+
+
 # tsbox 0.4.1  (2023-05-06)
 
 ## Bug fixes

diff --git a/R/ts_ggplot.R b/R/ts_ggplot.R
@@ -67,10 +67,13 @@ ts_ggplot <- function(..., title, subtitle, ylab = "") {
 
   n <- NCOL(df)
   stopifnot(n > 1L)
+  stime <- as.name(cname$time)
+  svalue <- as.name(cname$value)
+
   if (n == 2L) {
     p <- ggplot2::ggplot(
       df,
-      ggplot2::aes(x = !! cname$time, y = !! cname$value)
+      ggplot2::aes(x = !! stime, y = !! svalue)
     )
   } else if (n > 2) {
 
@@ -87,7 +90,7 @@ ts_ggplot <- function(..., title, subtitle, ylab = "") {
     }
     p <- ggplot2::ggplot(
       df,
-      ggplot2::aes(x = !! cname$time, y = !! cname$value, color = cname$id)
+      ggplot2::aes(x = !! stime, y = !! svalue)
     )
   }
   p <- p + ggplot2::geom_line()