Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CIR Image function #250

Closed
wants to merge 119 commits into from
Closed

Add CIR Image function #250

wants to merge 119 commits into from

Conversation

andschar
Copy link
Contributor

@andschar andschar commented May 6, 2020

This is a PR to add image retrieval functionality from CIR to webchem discussed in #249. It's not yet finished and here for further discussion. Hence, documentation and everything meta will follow once it is decided how to proceed with the image functions.

PR task list:

  • Update NEWS
  • Add tests (if appropriate)
  • Update documentation with devtools::document()
  • Check package passed

stitam and others added 30 commits April 16, 2020 09:48
…or expect_type, removing context(), moving skip_*() functions into test_that() blocks so they work, adding skip_on_travis() to chempsider tests, adding skip statements for ping_*() functions
Aariq and others added 27 commits May 18, 2020 13:24
… Extractors tests now all passing (except ci_ because it's broken).
Co-authored-by: Eric R Scott <[email protected]>
Merge branch 'dev_cir' of github.com:andschar/webchem into dev_cir

# Conflicts:
#	R/cir.R
@andschar andschar closed this Jul 14, 2020
@andschar andschar deleted the dev_cir branch July 14, 2020 12:24
@andschar andschar mentioned this pull request Jul 14, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images
4 participants