Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MultiThreadedExecutor spinning (backport #315) #319

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 3, 2024

I noticed that the MultiThreadedExecutor was not operating in a multi-threaded manner, so I made some changes.

From my review of the rclcpp code, it appears that the current rclcpp::MultiThreadedExecutor only implements spin(), and spin_once() and spin_some() simply execute the implementation from the base class rclcpp::Executor.

Implementation of MultiThreadedExecutor::spin():

Even after checking the implementation of rclcpp::Executor, I found no instances where the overridden spin is utilized. As a result, spin_once() and spin_some() seem to operate in a single-threaded mode. Indeed, in the header file of rclcpp::Executor, spin_some() and spin_once() are described as "suitable for a single-threaded model of execution."

Additionally, similar observations were made in a related pull request for rclcpp.
ros2/rclcpp#2454

There was also an old issue related to this problem, but it seems to have been closed without appropriate changes.
ros2/rclcpp#85

Therefore, in this pull request, I changed the implementation to use spin() instead of spin_once() for MultiThreadedExecutor. Consequently, the stop_ flag became unnecessary and was removed. It has been confirmed that the spin thread terminates correctly with executor_->cancel(), without using the stop_ flag.

As a side note, I would like to mention that MultiThreadedExecutor::spin() is also used in the ros2_control_node.


This is an automatic backport of pull request #315 done by Mergify.

…h MultiThreadedExecutor (#315)

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit 4503507)
@mergify mergify bot requested a review from ahcorde as a code owner June 3, 2024 08:51
@ahcorde ahcorde merged commit 80e6ad1 into jazzy Jun 3, 2024
4 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-315 branch June 3, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants