Skip to content

Commit

Permalink
[CI] reviewer lottery and fail-fast (backport #1047 #1049) (#1055)
Browse files Browse the repository at this point in the history
  • Loading branch information
christophfroehlich authored Feb 27, 2024
1 parent 0cfe23e commit e341d4b
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 41 deletions.
33 changes: 0 additions & 33 deletions .github/reviewer-lottery.yml

This file was deleted.

1 change: 1 addition & 0 deletions .github/workflows/humble-binary-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
binary:
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-industrial-ci-with-cache.yml@master
strategy:
fail-fast: false
matrix:
ROS_REPO: [main, testing]
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/humble-semi-binary-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
semi_binary:
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-industrial-ci-with-cache.yml@master
strategy:
fail-fast: false
matrix:
ROS_REPO: [main, testing]
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/iron-binary-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
binary:
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-industrial-ci-with-cache.yml@master
strategy:
fail-fast: false
matrix:
ROS_REPO: [main, testing]
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/iron-semi-binary-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
semi_binary:
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-industrial-ci-with-cache.yml@master
strategy:
fail-fast: false
matrix:
ROS_REPO: [main, testing]
with:
Expand Down
12 changes: 4 additions & 8 deletions .github/workflows/reviewer_lottery.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
name: Reviewer lottery
# pull_request_target takes the same events as pull_request,
# but it runs on the base branch instead of the head branch.
on:
pull_request_target:
types: [opened, ready_for_review, reopened]

jobs:
test:
runs-on: ubuntu-latest
if: github.actor != 'dependabot[bot]' && github.actor != 'mergify[bot]'
steps:
- uses: actions/checkout@v4
- uses: uesteibar/reviewer-lottery@v3
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
assign_reviewers:
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-reviewer-lottery.yml@master
1 change: 1 addition & 0 deletions .github/workflows/rolling-binary-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
binary:
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-industrial-ci-with-cache.yml@master
strategy:
fail-fast: false
matrix:
ROS_REPO: [main, testing]
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/rolling-semi-binary-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
semi_binary:
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-industrial-ci-with-cache.yml@master
strategy:
fail-fast: false
matrix:
ROS_REPO: [main, testing]
with:
Expand Down

0 comments on commit e341d4b

Please sign in to comment.