-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCA, build and namespace Fixes #32
PCA, build and namespace Fixes #32
Conversation
@akgoins and @geoffreychiou I am working on the #11 |
@jontromanab I have not started working on it yet, if you have already started please continue, I can find something else.
|
@geoffreychiou I am currently working on #11 #30 and #16 |
@geoffreychiou, Sorry, but merging the other PR has broken this one. Please resolve conflict and I will review as soon as possible. |
@akgoins I have resolved the conflict, please check whenever you have some free time.
|
|
||
|
||
catkin_add_gtest(utest test/utest.cpp) | ||
target_link_libraries(utest sphere_discretization ${catkin_LIBRARIES}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the catkin tests should be enclosed with the if statement below so the the gtest does not build every time.
if(CATKIN_ENABLE_TESTING)
catkin_add_gtest(utest test/utest.cpp)
target_link_libraries(utest sphere_discretization ${catkin_LIBRARIES})
endif()
kinematics::Kinematics k; | ||
std::string ext = ".h5"; | ||
std::string filename = | ||
std::string(k.getRobotName()) + "_" + "r" + str(boost::format("%d") % resolution) + "_" + "reachability" + "." + "h5"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest using boost::format for everything. I have not tested it, but it should work.
str(boost::format("%s_r%d_reachability.h5" % k.getRobotName() % resolution));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to move the ')' inside to get it to build.
str(boost::format("%s_r%d_reachability.h5") % k.getRobotName() % resolution);
Thanks for the suggestions.
@geoffreychiou, if you could make the two changes that Levi mentioned, I will merge this PR. |
@akgoins, I have added the changes Levi suggested. |
+1 |
@akgoins Please review.