Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add new packages. #67

Merged
merged 2 commits into from
May 26, 2017

Conversation

gavanderhoorn
Copy link
Member

As per subject.

@gavanderhoorn gavanderhoorn requested a review from AustinDeric May 26, 2017 11:49
<exec_depend>abb_irb2600_support</exec_depend>
<exec_depend>abb_irb4600_support</exec_depend>
<exec_depend>abb_irb52_support</exec_depend>
<exec_depend>abb_irb6650s_support</exec_depend>
<exec_depend>abb_irb7600_support</exec_depend>

<export>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add <architecture_independent/> ?

https://github.com/ros-infrastructure/rep/blob/240583e7c1b5148e0dc939bd40a628fda047aa26/rep-0140.rst#architecture_independent

"Specifying <architecture_independent/> is recommended for metapackages..."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed that one.

Done now.

@AustinDeric
Copy link
Contributor

AustinDeric commented May 26, 2017

These new packages add pressure to a solution for #46, transitioning robots to abb.

@gavanderhoorn
Copy link
Member Author

@AustinDeric wrote:

These new packages add pressure to a solution for #46, transitioning robots to abb.

why exactly?

@AustinDeric
Copy link
Contributor

+1 Thank you!

@AustinDeric AustinDeric merged commit b577779 into ros-industrial:kinetic-devel May 26, 2017
@gavanderhoorn gavanderhoorn deleted the update_meta branch May 27, 2017 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants