Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REP-2012] Service introspection #360

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[REP-2012] Service introspection #360

wants to merge 8 commits into from

Commits on Feb 28, 2023

  1. Add draft for REP about service intropsection 

    * Add content for motivation, specification, and rationale.
* Feature progress is left as TODO as we've just been prototyping
* Add "Other" section will examples of tooling leveraging the proposed feature

Co-authored-by: Aditya Pande <[email protected]>
Co-authored-by: Brian Chen <[email protected]>
Co-authored-by: Deepanshu Bansal <[email protected]>

Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron @clalancette
    jacobperron authored and clalancette committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    abef217 View commit details
    Browse the repository at this point in the history

  2. Use one message definition per service 

    * Move metadata into common ServiceEventInfo message
* Generate one event message per service containing an optional request or response
* Minor rewording

Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron @clalancette
    jacobperron authored and clalancette committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    5816be4 View commit details
    Browse the repository at this point in the history

  3. Replace SROS 2 reference with link to paper 

    Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron @clalancette
    jacobperron authored and clalancette committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    ffb13c8 View commit details
    Browse the repository at this point in the history

  4. Use the term 'server' instead of 'service' 

    Trying to make clear the distinction between 'services' as the larger concept and service 'servers' as one half of a service interaction.

Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron @clalancette
    jacobperron authored and clalancette committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    9c6a95e View commit details
    Browse the repository at this point in the history

  5. Minor additions + single event type discussion 

    Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron @clalancette
    jacobperron authored and clalancette committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    81b190b View commit details
    Browse the repository at this point in the history

  6. Add post date and link to discussion 

    Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron @clalancette
    jacobperron authored and clalancette committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    0128d3c View commit details
    Browse the repository at this point in the history

  7. Update feature progress 

    Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron @clalancette
    jacobperron authored and clalancette committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    655236c View commit details
    Browse the repository at this point in the history

  8. Revamp of REP-2012 according to the merged implementation. 

    Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    336d3b6 View commit details
    Browse the repository at this point in the history