REP 124 update strategy for package-relative executables #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Updated issue title to more specific description. |
| specification for an install tree. | ||
| In an install tree as well as for executables being built the | ||
| executable is looked up in the folder ``lib/ros-package-name``. | ||
| Than ``rosrun`` will crawl the package directory recursively for |
|
Should the roscore launchfile be called "roscore.xml" or "roscore.launch"? |
|
@jbohren This pull request does not touch that part of the REP. The file is called |
|
@dirk-thomas Just curious. |
|
I think it's a legitimate question, Jon. But, that name is widely deployed already. Changing it would almost certainly be more trouble than makes sense. Eventually, probably for Indigo, we should move those |
|
Updated. |
|
+1 this looks OK to me. Is it ready for acceptance? |
|
+1 |
1 similar comment
|
+1 |
dirk-thomas
added a commit
that referenced
this pull request
Oct 3, 2013
REP 124 update strategy for package-relative executables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REP 124 update strategy for package-relative executables