Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add package.xml to standard documents #115

Merged
merged 1 commit into from
Apr 19, 2024
Merged

add package.xml to standard documents #115

merged 1 commit into from
Apr 19, 2024

Conversation

rkent
Copy link
Contributor

@rkent rkent commented Apr 18, 2024

@tfoote suggested that package.xml be displayed. Here it is.

tfoote
tfoote approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great to add to the standard docs. I think that getting most of the information onto the landing page will also be valuable eventually, but we may want to think a bit more holistically about this especially with cross referencing.

@tfoote tfoote merged commit bc9e56a into ros-infrastructure:main Apr 19, 2024
4 checks passed
@tfoote tfoote mentioned this pull request Apr 19, 2024
Open
@rkent rkent deleted the show-package-xml branch April 21, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkent @tfoote