cmake helper function and tool to auto generate TreeNodeModel xml files for groot #4903
Conversation
Use this to generate tree nodes file for opennav_docking_bt Signed-off-by: Mike Wake <[email protected]>
ewak
force-pushed
the
feature/mw/bt_tree_node_generation
branch
from
a751ee4 to
174bd73
Compare
This cmake function takes care of generating and installing TreeNodesModel xml file suitable for use by groot. Signed-off-by: Mike Wake <[email protected]> sq
ewak
force-pushed
the
feature/mw/bt_tree_node_generation
branch
from
174bd73 to
685dd25
Compare
|
@ewak, your PR has failed to build. Please check CI outputs and resolve issues. |
There was a problem hiding this comment.
Some other thoughts:
I remember chatting about this back when the plugins list for BT Navigator had the libraries stored in a similar way (as you've found here) that we weren't sure how to automatically update the groot XML in source as might be necessary for use. That way, we don't need to manually manage it ever again, it automatically updates on commit / merge.
Or, a GitHub Action job runs to run this over and if it detects a problem it fails the job to make a human make the update for their violating PR. Verification is less ideal than automation, but verification is still very useful.
| DESTINATION share/${PROJECT_NAME} | ||
| ) | ||
|
|
||
| #NOTE: Still using manually managed nav2_tree_nodes.xml in source directory |
There was a problem hiding this comment.
Should we though? If we removed this, what would be the workflow for using groot?
| @@ -0,0 +1,28 @@ | |||
| <root BTCPP_format="4"> | |||
There was a problem hiding this comment.
Is the other Groot XML in the nav2_behavior_tree package not also needing an update?
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers: