Skip to content
This repository was archived by the owner on Dec 14, 2022. It is now read-only.

[WIP] Option to create a deployable runtime image #200

Closed
wants to merge 1 commit into from

Conversation

emersonknapp
Copy link
Contributor

Consider this a preview branch for now. Works great but has no tests yet.

Adds an option to the build to create a "runtime docker image". This image contains the created portable install directory created by the build, and its default entrypoint is a shell that sources its setup.bash. This means a user can do soemething like the following

ros_cross_compile $(pwd) -a aarch64 -d dashing -o ubuntu --create-runtime-image my-runtime
docker run -it my-runtime
# in the container
ros2 launch my_package my.launch.py

The image is ready to push to a registry and pulled onto a target device to use with whatever combination of docker/rocker arguments desired.

Signed-off-by: Emerson Knapp [email protected]

logging.basicConfig(level=logging.INFO)
logger = logging.getLogger(__name__)


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstring please

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant L26. Can you add docstring to the function?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have a linter for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ament_flake8 disables the docstring requirement. I'll add it, good call 👍

@vishalsinghdeepak
Copy link

vishalsinghdeepak commented Jun 9, 2020

--create-runtime-image option only accepts lowercase characters. It breaks for Uppercase (not sure about other character (special chars or numbers))

@emersonknapp
Copy link
Contributor Author

Going to reopen with a new approach to this code based on architecture changes in the package

@emersonknapp emersonknapp deleted the emersonknapp/runtime-image branch September 23, 2020 19:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants