Skip to content
This repository was archived by the owner on Dec 14, 2022. It is now read-only.

Source /custom-data/setup.bash on sysroot build #322

Merged
merged 4 commits into from
Jun 11, 2021

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Jun 8, 2021

Just a means to control the build environment. I do not have a strong opinion about how this is achieved (as long as there is a way). As such, I'm open to completely changing this patch if a more suitable alternative exists.

Thanks for the tool BTW !

@hidmic hidmic requested a review from a team as a code owner June 8, 2021 19:39
@hidmic hidmic requested review from emersonknapp and christophebedard and removed request for a team June 8, 2021 19:39
Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I've got no concerns with this

@emersonknapp emersonknapp enabled auto-merge (squash) June 8, 2021 20:29
@hidmic
Copy link
Contributor Author

hidmic commented Jun 9, 2021

Most jobs are failing because of unrelated reasons. I have to take a closer look at the shellcheck one though.

auto-merge was automatically disabled June 9, 2021 13:03

Head branch was pushed to by a user without write access

hidmic added 3 commits June 9, 2021 10:04
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
@hidmic hidmic force-pushed the custom-data-setup branch from 71077ac to 82eb1c4 Compare June 9, 2021 13:05
@hidmic
Copy link
Contributor Author

hidmic commented Jun 9, 2021

Rebased to please workflows.

@hidmic hidmic requested a review from emersonknapp June 9, 2021 14:29
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #322 (acaa7c1) into master (2795a54) will not change coverage.
The diff coverage is n/a.

❗ Current head acaa7c1 differs from pull request most recent head eb499d9. Consider uploading reports for the commit eb499d9 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #322   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files          11       11           
  Lines         414      414           
=======================================
  Hits          386      386           
  Misses         28       28           
Flag Coverage Δ
unittests 93.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2795a54...eb499d9. Read the comment docs.

@emersonknapp emersonknapp enabled auto-merge (squash) June 11, 2021 19:44
@emersonknapp emersonknapp merged commit c5cb4de into ros-tooling:master Jun 11, 2021
@TSC21
Copy link
Contributor

TSC21 commented Jun 12, 2021

Does this mean we can eventually use this to support workspace overlaying and so answer to #299?

@emersonknapp
Copy link
Contributor

It seems like you could mount an underlay workspace into the custom-data-dir, then source it in custom-data/setup.bash - so theoretically yes, though I haven't tried it. Would love to hear back if that works, and if so, an addition to the README explaining this workflow would be really useful.

@hidmic hidmic deleted the custom-data-setup branch June 15, 2021 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants