-
Notifications
You must be signed in to change notification settings - Fork 60
Source /custom-data/setup.bash on sysroot build #322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I've got no concerns with this
Most jobs are failing because of unrelated reasons. I have to take a closer look at the |
Head branch was pushed to by a user without write access
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Rebased to please workflows. |
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
=======================================
Coverage 93.23% 93.23%
=======================================
Files 11 11
Lines 414 414
=======================================
Hits 386 386
Misses 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Does this mean we can eventually use this to support workspace overlaying and so answer to #299? |
It seems like you could mount an underlay workspace into the |
Just a means to control the build environment. I do not have a strong opinion about how this is achieved (as long as there is a way). As such, I'm open to completely changing this patch if a more suitable alternative exists.
Thanks for the tool BTW !