Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GHA set-output command warning #439

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

jballoffet
Copy link
Contributor

@jballoffet jballoffet commented Nov 29, 2024

Description

This PR fixes a GitHub Action warning related to using the deprecated set-output command.

Context

See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/.

Change involved

This PR applies the following changes:

  • Removes the command in favor of environment files as indicated by the documentation.

How was this tested?

CI should pass and warning message shall be gone.

@jballoffet jballoffet force-pushed the jballoffet/fix-gha-warning branch 3 times, most recently from c1e660a to 1a0aa0f Compare November 29, 2024 14:16
@mxgrey
Copy link
Collaborator

mxgrey commented Dec 2, 2024

The CI failures were fixed by #441 so be sure to merge in the latest main to get your CI passing.

Signed-off-by: Javier Balloffet <[email protected]>
@jballoffet jballoffet force-pushed the jballoffet/fix-gha-warning branch from 1a0aa0f to 4604f11 Compare December 2, 2024 16:43
@maspe36 maspe36 merged commit 6ac2ae1 into ros2-rust:main Dec 2, 2024
6 checks passed
@jballoffet jballoffet deleted the jballoffet/fix-gha-warning branch December 2, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants