Add return code to CancelGoal service response #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Jacob Perron <[email protected]>
…dd tests Refactored the callback signature for canceling one goal. Now it is the same as the other cancel methods. This makes it easier to communicate the error code to the user. Signed-off-by: Jacob Perron <[email protected]>
jacobperron
added
in progress
Signed-off-by: Jacob Perron <[email protected]>
|
CI with connected PRs
EDIT: retriggered due to unrelated failures |
|
CI failures look unrelated, so I'm going to go ahead and merge this and the connected PRs. |
cho3
pushed a commit
to cho3/rclcpp
that referenced
this pull request
Jun 3, 2019
* Populate return code of CancelGoal service response Signed-off-by: Jacob Perron <[email protected]> * Throw if there is an error processing a cancel goal request Signed-off-by: Jacob Perron <[email protected]> * Make cancel callback signature consistent across cancel methods and add tests Refactored the callback signature for canceling one goal. Now it is the same as the other cancel methods. This makes it easier to communicate the error code to the user. Signed-off-by: Jacob Perron <[email protected]> * Address review Signed-off-by: Jacob Perron <[email protected]>
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
…TimeControllerClock (ros2#710) * Enable thread safety analysis for rosbag2_cpp and add annotations in TimeControllerClock Signed-off-by: Emerson Knapp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the callback signature for canceling one goal. Now it is the same as the other cancel methods.
This makes it easier to communicate the error code to the user.
Connects to ros2/rcl_interfaces#63