Add ament_xmllint test by default to ament_python packages. (#957)

Signed-off-by: Chris Lalancette <[email protected]>

ros2pkg/ros2pkg/api/create.py

@@ -186,6 +186,11 @@ def populate_ament_python(package, package_directory, source_directory, python_n
                           test_directory,
                           'test_pep257.py',
                           {})
+    _create_template_file('ament_python',
+                          'test_xmllint.py.em',
+                          test_directory,
+                          'test_xmllint.py',
+                          {})
 
 
 def populate_python_node(package, source_directory, python_node_name):

ros2pkg/ros2pkg/resource/ament_python/test_xmllint.py.em

@@ -0,0 +1,23 @@
+# Copyright 2015 Open Source Robotics Foundation, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+from ament_xmllint.main import main
+import pytest
+
+
+@@pytest.mark.linter
+@@pytest.mark.xmllint
+def test_xmllint() -> None:
+    rc = main(argv=[])
+    assert rc == 0, 'Found code style errors / warnings'

ros2pkg/ros2pkg/verb/create.py

@@ -138,7 +138,7 @@ def main(self, *, args):
             test_dependencies = ['ament_lint_auto', 'ament_lint_common']
         if args.build_type == 'ament_python':
             test_dependencies = ['ament_copyright', 'ament_flake8', 'ament_pep257',
-                                 'python3-pytest']
+                                 'ament_xmllint', 'python3-pytest']
 
         if args.build_type == 'ament_python' and args.package_name == 'test':
             # If the package name is 'test', there will be a conflict between