-
Notifications
You must be signed in to change notification settings - Fork 247
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Address flakiness in rosbag2_play_end_to_end tests (#1297)
* Make test_rosbag2_play_end_to_end more deterministic - Change QoS depth in test databases to correspond number of messages - Change QoS durability to transient local in test DB and mcap file - Explicitly specify QoS depth = 10 for subscribers - Explicitly specify QoS reliability to reliable for subscribers - Explicitly specify QoS durability to transient local for subscribers - Update metadata in test DB and mcap files to the latest version(7) - Remove xfail test_rosbag2_play_end_to_end Signed-off-by: Michael Orlov <[email protected]> * Add wait_for_matched for record_end_to_end_exits_gracefully_on_sigterm - Remove xfail for test_rosbag2_info_end_to_end Signed-off-by: Michael Orlov <[email protected]> * Fix for play_filters_by_topic test - Uncomment play_filters_by_topic test - Use proper qos settings for subscribers in `play_filters_by_topic` and fix expectations about number of published messages. - Log warning if SubscriptionManager::continue_spinning(..) finished by timeout. - Enable `play_end_to_end_test` for windows. Signed-off-by: Michael Orlov <[email protected]> * Make test_rosbag2_play_end_to_end deterministic - Start player in pause mode and wait on subscribers for matched publishers from player then send resume service call to unpause. - Add spin_and_wait_for_matched(topic_names) for SubscriptionManager Signed-off-by: Michael Orlov <[email protected]> * Remove redundant includes from test_rosbag2_play_end_to_end.cpp Signed-off-by: Michael Orlov <[email protected]> * Sleep for a few milliseconds in SubscriptionManager to avoid busy loop Signed-off-by: Michael Orlov <[email protected]> * Update rosbag2_test_common/include/rosbag2_test_common/subscription_manager.hpp Co-authored-by: Chris Lalancette <[email protected]> Signed-off-by: Michael Orlov <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> * Add missing include<thread> in process_execution_helpers_unix.hpp Signed-off-by: Michael Orlov <[email protected]> * Address race condition in process termination routines - Added wait_until_completion(process_id, timeout) helper function Signed-off-by: Michael Orlov <[email protected]> * Move wait_until_completion before stop_execution to fix compilation error Signed-off-by: Michael Orlov <[email protected]> * Fix for Windows build error. Rename process_id to handle. Signed-off-by: Michael Orlov <[email protected]> * Increase timeout for service call and wait_until_completion up to 10 sec Signed-off-by: Michael Orlov <[email protected]> --------- Signed-off-by: Michael Orlov <[email protected]> Co-authored-by: Chris Lalancette <[email protected]>
- Loading branch information
1 parent
f3bc1af
commit af4ca0c
Showing
11 changed files
with
337 additions
and
143 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,35 @@ | ||
rosbag2_bagfile_information: | ||
version: 4 | ||
version: 7 | ||
storage_identifier: sqlite3 | ||
relative_file_paths: | ||
- cdr_test_0.db3 | ||
duration: | ||
nanoseconds: 151137181 | ||
starting_time: | ||
nanoseconds_since_epoch: 1586406456763032325 | ||
message_count: 7 | ||
topics_with_message_count: | ||
- topic_metadata: | ||
name: /test_topic | ||
type: test_msgs/msg/BasicTypes | ||
serialization_format: cdr | ||
offered_qos_profiles: "- history: 3\n depth: 0\n reliability: 1\n durability: 2\n deadline:\n sec: 0\n nsec: 0\n lifespan:\n sec: 0\n nsec: 0\n liveliness: 1\n liveliness_lease_duration:\n sec: 0\n nsec: 0\n avoid_ros_namespace_conventions: false" | ||
message_count: 3 | ||
- topic_metadata: | ||
name: /array_topic | ||
type: test_msgs/msg/Arrays | ||
serialization_format: cdr | ||
offered_qos_profiles: "- history: 3\n depth: 0\n reliability: 1\n durability: 2\n deadline:\n sec: 0\n nsec: 0\n lifespan:\n sec: 0\n nsec: 0\n liveliness: 1\n liveliness_lease_duration:\n sec: 0\n nsec: 0\n avoid_ros_namespace_conventions: false" | ||
offered_qos_profiles: "- history: 3\n depth: 4\n reliability: 1\n durability: 1\n deadline:\n sec: 0\n nsec: 0\n lifespan:\n sec: 0\n nsec: 0\n liveliness: 1\n liveliness_lease_duration:\n sec: 0\n nsec: 0\n avoid_ros_namespace_conventions: false" | ||
type_description_hash: "" | ||
message_count: 4 | ||
- topic_metadata: | ||
name: /test_topic | ||
type: test_msgs/msg/BasicTypes | ||
serialization_format: cdr | ||
offered_qos_profiles: "- history: 3\n depth: 3\n reliability: 1\n durability: 1\n deadline:\n sec: 0\n nsec: 0\n lifespan:\n sec: 0\n nsec: 0\n liveliness: 1\n liveliness_lease_duration:\n sec: 0\n nsec: 0\n avoid_ros_namespace_conventions: false" | ||
type_description_hash: "" | ||
message_count: 3 | ||
compression_format: "" | ||
compression_mode: "" | ||
relative_file_paths: | ||
- cdr_test_0.db3 | ||
files: | ||
- path: cdr_test_0.db3 | ||
starting_time: | ||
nanoseconds_since_epoch: 1586406456763032325 | ||
duration: | ||
nanoseconds: 151137181 | ||
message_count: 7 | ||
custom_data: ~ |
Oops, something went wrong.