Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jazzy] Bugfix for wrong timestamps in ros2 bag info (backport #1745) #1752

Merged
merged 1 commit into from
Jul 19, 2024
Merged

[jazzy] Bugfix for wrong timestamps in ros2 bag info (backport #1745) #1752

merged 1 commit into from
Jul 19, 2024

Commits on Jul 19, 2024

  1. Bugfix for wrong timestamps in ros2 bag info (#1745) 

    * Bugfix for wrong timestamps in ros2 bag info

- Correctly calculate fractional part for seconds by subtracting
`nanoseconds_from_seconds` from `nanoseconds`.

Signed-off-by: Michael Orlov <[email protected]>

* Adjust expectations in the "ros2 bag info" integration tests

Signed-off-by: Michael Orlov <[email protected]>

* Add leading zeros to the fractional seconds in the format_duration(..)

Signed-off-by: Michael Orlov <[email protected]>

* Adjust expectations in info end-to-end tests by adding leading zero

The real file duration is: 70633730 nanoseconds.
i.e., regex mask shall be "0\\.0706.*s" to match 070633730 nanoseconds.

Signed-off-by: Michael Orlov <[email protected]>

---------

Signed-off-by: Michael Orlov <[email protected]>
(cherry picked from commit da28c9d)
    @MichaelOrlov @mergify
    MichaelOrlov authored and mergify[bot] committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    c1914af View commit details
    Browse the repository at this point in the history