Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jazzy] Small cleanups to the rosbag2 tests. (backport #1792) #1793

Merged
merged 1 commit into from
Sep 5, 2024
Merged

[jazzy] Small cleanups to the rosbag2 tests. (backport #1792) #1793

merged 1 commit into from
Sep 5, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 23, 2024

  1. Rename "wait_for_srvice_to_be_ready" to "wait_for_service_to_be_ready".
  2. Make some of the constants constexpr, so we no longer have to capture them.
    This is an automatic backport of pull request Small cleanups to the rosbag2 tests. #1792 done by Mergify.

@clalancette @mergify
Small cleanups to the rosbag2 tests. (#1792)
d6fd40f 
* Small cleanups to the rosbag2 tests.

1.  Rename "wait_for_srvice_to_be_ready" to "wait_for_service_to_be_ready".
2.  Make some of the constants constexpr, so we no longer have to capture them.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit 604cebc)
@mergify mergify bot requested a review from a team as a code owner August 23, 2024 20:16
@mergify mergify bot requested review from gbiggs and jhdcs and removed request for a team August 23, 2024 20:16
@mergify mergify bot mentioned this pull request Aug 23, 2024
Merged
@MichaelOrlov MichaelOrlov changed the title Small cleanups to the rosbag2 tests. (backport #1792) [jazzy] Small cleanups to the rosbag2 tests. (backport #1792) Aug 23, 2024
@MichaelOrlov
Copy link
Contributor

Pulls: #1793
Gist: https://gist.githubusercontent.com/MichaelOrlov/b1d0577680a1fd33b7a1a8cd998040ca/raw/6b8e7103bb97cedf403fc206a6ef5170163ee216/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_transport rosbag2_test_common rosbag2_tests
TEST args: --packages-above rosbag2_transport rosbag2_test_common rosbag2_tests
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14513

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@MichaelOrlov
Copy link
Contributor

The new warnings on the Linux-rhel

rti_build_helper.cmake:380
no CONNEXTDDS_DIR nor NDDSHOME specified

Is unrelated, and I believe it is due to some infrastructure issue.
Merging then.

@MichaelOrlov MichaelOrlov merged commit 865b864 into jazzy Sep 5, 2024
12 checks passed
@mergify mergify bot deleted the mergify/bp/jazzy/pr-1792 branch September 5, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelOrlov MichaelOrlov MichaelOrlov approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner automatically assigned from ros2/tooling-reviewers

@jhdcs jhdcs Awaiting requested review from jhdcs jhdcs is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelOrlov @clalancette