Removed warnings #1794
Merged
Removed warnings #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
ahcorde
requested review from
MichaelOrlov and
hidmic
and removed request for
a team
|
clalancette
requested changes
Aug 27, 2024
There was a problem hiding this comment.
Arg. We can't do this because this won't compile on MSVC; see #1792 (review) .
I think the best we can do here is switch the expected_messages back to just a const size_t, and then keep the captures. I think that should make both Windows and Clang happy.
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
|
@clalancette and @fujitatomoya what about this solution ? I used a similar approach in other similar cases like this one https://github.com/ros2/geometry2/pull/682/files |
|
|
Here's also a Clang run to ensure that this fixes it on Clang:
|
clalancette
approved these changes
Aug 28, 2024
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
* Removed warnings * compile with windows * make linters happy Signed-off-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 88c51a1)
MichaelOrlov
pushed a commit
that referenced
this pull request
Sep 18, 2024
* Removed warnings * compile with windows * make linters happy Signed-off-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 88c51a1) Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some new warnings on clang https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/1993/gcc/new/folder.1817012694/