update documentation for rosbag2 composable player

[berndpfrommer]

all: true should read all_topics: true

This was brought to my attention on the robotics stack exchange here

[fujitatomoya]

lgtm.

rosbag2/rosbag2_transport/src/rosbag2_transport/config_options_from_node_params.cpp

Line 246 in efd8d39

record_options.all_topics = node.declare_parameter<bool>("record.all_topics", false);

[MichaelOrlov]

@berndpfrommer Could you please elaborate why it is should be all_topics instead of all?

Inspight the fact that we added recently a new CLI options like --all-topics and --all-service we still have --all CLI option which will "Record all topics and services (Exclude hidden topic)"

[berndpfrommer]

I had a superficial look at the README, saw only "all_topics" mentioned, and uncritically assumed the failure report on stack exchange was correct.
I wonder if the user is on the latest update. Do I understand correctly that all will only work if this commit is being used? That one is fairly recent...

[MichaelOrlov]

Ahh you are right, I've already forgotten that we had a compatibility issue in yaml parser and that I've fixed in the #1664.

Anyway, in the current state, everything should be up to date, even on a new Jazzy release and there is no need to update documentation.

[berndpfrommer]

OK, closing this PR then.