Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort info output by topic name #1804

Open
wants to merge 11 commits into
base: rolling
Choose a base branch
from
Open

Sort info output by topic name #1804

wants to merge 11 commits into from

Commits on Sep 13, 2024

  1. sort info output by topic name 

    Signed-off-by: Soenke Prophet <[email protected]>
    Soenke Prophet committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    8645046 View commit details
    Browse the repository at this point in the history

  2. add missing imports 

    Signed-off-by: Soenke Prophet <[email protected]>
    Soenke Prophet committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5dd5009 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. add sorting to service topics and remove sorting option by serializat… 

    …ion format

Signed-off-by: Soenke Prophet <[email protected]>
    Soenke Prophet committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b6427eb View commit details
    Browse the repository at this point in the history

  2. add CLI option for sorting output and move sorting methods to enum 

    Signed-off-by: Soenke Prophet <[email protected]>
    Soenke Prophet committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    60ea4c9 View commit details
    Browse the repository at this point in the history

  3. add sorting by name to topic only option of info output 

    Signed-off-by: Soenke Prophet <[email protected]>
    Soenke Prophet committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2778bf7 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. move InfoSortingMethod and generate sorted idx functions to seprate f… 

    …iles; move ServiceInformation and ServiceMetadata struct to storage package for clear include structure

Signed-off-by: Soenke Prophet <[email protected]>
    Soenke Prophet committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    5603870 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. move ServiceInformation struct to its own header file and rename to S… 

    …erviceEventInformation; replace if-else by switch-case for differantiating between sorting methods; bugfix sorting method from string resolution and service info verbose not being sorted

Signed-off-by: Soenke Prophet <[email protected]>
    Soenke Prophet committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    abd6946 View commit details
    Browse the repository at this point in the history

  2. add test-cases for sorted info output 

    Signed-off-by: Soenke Prophet <[email protected]>
    Soenke Prophet committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    043a6bf View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Fix linker issues 

    - Add missing const qualifier for the generate_sorted_idx(..) version
with rosbag2_cpp::rosbag2_service_info_t
- Small cleanups

Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    8bc0e60 View commit details
    Browse the repository at this point in the history

  2. Regenerate pyi stub files 

    Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    5d44187 View commit details
    Browse the repository at this point in the history

  3. Small nitpick for using const reference in the for loop 

    Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    454053b View commit details
    Browse the repository at this point in the history