Bugfix: Event publisher not starting for second run Recorder::Record() after Stop() #1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Orlov <[email protected]>
MichaelOrlov
force-pushed
the
morlov/bugfix_event_pub_not_starting_for_second_run
branch
from
6ba853b to
de9782f
Compare
|
Pulls: #1888
|
MichaelOrlov
deleted the
morlov/bugfix_event_pub_not_starting_for_second_run
branch
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 30, 2024
Signed-off-by: Michael Orlov <[email protected]> (cherry picked from commit ffd8c7d)
MichaelOrlov
added a commit
that referenced
this pull request
Jan 28, 2025
#1890) Signed-off-by: Michael Orlov <[email protected]> (cherry picked from commit ffd8c7d) Co-authored-by: Michael Orlov <[email protected]>
nicolaloi
pushed a commit
to nicolaloi/rosbag2
that referenced
this pull request
Jan 30, 2025
…1888) Signed-off-by: Michael Orlov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug when the event publisher thread, which is responsible for publishing
on_bag_split_eventevents, doesn't start when callingRecorder::Record()after a previous call toRecorder::Stop().RCA: The event publisher thread was starting and exiting immediately because
event_publisher_thread_should_exit_was not initialized to false after calling theRecorder::Stop()API.