Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase length of pipe name to make collisions less likely #488

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Increase length of pipe name to make collisions less likely #488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef2b4be
Increase length of pipe name to make collisions less likely
reima Nov 30, 2023
c9e0cde
Fix typo
reima Nov 30, 2023
ee48cc1
Merge branch 'main' into feature/longer-pipe-name
rosenbjerg Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion FFMpegCore/FFMpeg/Arguments/PipeArgument.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public abstract class PipeArgument

protected PipeArgument(PipeDirection direction)
{
PipeName = PipeHelpers.GetUnqiuePipeName();
PipeName = PipeHelpers.GetUniquePipeName();
_direction = direction;
}

Expand Down
2 changes: 1 addition & 1 deletion FFMpegCore/FFMpeg/Pipes/PipeHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ namespace FFMpegCore.Pipes
{
internal static class PipeHelpers
{
public static string GetUnqiuePipeName() => $"FFMpegCore_{Guid.NewGuid().ToString("N").Substring(0, 5)}";
public static string GetUniquePipeName() => $"FFMpegCore_{Guid.NewGuid().ToString("N").Substring(16, 16)}";

public static string GetPipePath(string pipeName)
{
Expand Down
Loading