Skip to content

Commit

Permalink
Add deprecation warning in UI for moment map export (spacetelescope#2779
Browse files Browse the repository at this point in the history
)

* Add deprecation warning in UI

* Apply suggestion.

Co-authored-by: P. L. Lim <[email protected]>

* Add warning to other Save as FITS buttons

---------

Co-authored-by: P. L. Lim <[email protected]>
  • Loading branch information
rosteen and pllim authored Apr 2, 2024
1 parent f841687 commit 3ced249
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 8 deletions.
6 changes: 6 additions & 0 deletions jdaviz/configs/cubeviz/plugins/moment_maps/moment_maps.vue
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,12 @@
</v-text-field>
</v-row>

<v-row>
<span class="v-messages v-messages__message text--secondary" style="color: red !important">
DeprecationWarning: Save as FITS functionality has moved to the Export plugin as of v3.9 and will be removed from Moment Maps plugin in a future release.
</span>
</v-row>

<v-row justify="end">
<j-tooltip tipid='plugin-moment-save-fits'>
<v-btn color="primary" text @click="save_as_fits">Save as FITS</v-btn>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
<div @mouseover="() => active_step='ap'">
<j-plugin-section-header :active="active_step==='ap'">Aperture</j-plugin-section-header>

<plugin-subset-select
<plugin-subset-select
:items="aperture_items"
:selected.sync="aperture_selected"
:show_if_single_entry="true"
Expand Down Expand Up @@ -87,7 +87,7 @@

<div v-if="dev_bg_support" @mouseover="() => active_step='bg'">
<j-plugin-section-header :active="active_step==='bg'">Background</j-plugin-section-header>
<plugin-subset-select
<plugin-subset-select
:items="bg_items"
:selected.sync="bg_selected"
:show_if_single_entry="true"
Expand Down Expand Up @@ -225,6 +225,12 @@
</v-text-field>
</v-row>

<v-row>
<span class="v-messages v-messages__message text--secondary" style="color: red !important">
DeprecationWarning: Save as FITS functionality has moved to the Export plugin as of v3.9 and will be removed from here in a future release.
</span>
</v-row>

<v-row justify="end">
<j-tooltip tipid='plugin-extract-save-fits'>
<v-btn color="primary" text @click="save_as_fits">Save as FITS</v-btn>
Expand All @@ -240,10 +246,10 @@
opacity=1.0
:value="overwrite_warn && export_enabled"
:zIndex=3
style="grid-area: 1/1;
style="grid-area: 1/1;
margin-left: -24px;
margin-right: -24px">

<v-card color="transparent" elevation=0 >
<v-card-text width="100%">
<div class="white--text">
Expand Down
14 changes: 10 additions & 4 deletions jdaviz/configs/default/plugins/collapse/collapse.vue
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
></v-select>
</v-row>

<plugin-subset-select
<plugin-subset-select
:items="spectral_subset_items"
:selected.sync="spectral_subset_selected"
:has_subregions="spectral_subset_selected_has_subregions"
Expand Down Expand Up @@ -66,6 +66,12 @@
</v-text-field>
</v-row>

<v-row>
<span class="v-messages v-messages__message text--secondary" style="color: red !important">
DeprecationWarning: Save as FITS functionality has moved to the Export plugin as of v3.9 and will be removed from here in a future release.
</span>
</v-row>

<v-row justify="end">
<j-tooltip tipid='plugin-collapse-save-fits'>
<v-btn color="primary" text @click="save_as_fits">Save as FITS</v-btn>
Expand All @@ -75,16 +81,16 @@

</div>
</div>

<v-overlay
absolute
opacity=1.0
:value="overwrite_warn && export_enabled"
:zIndex=3
style="grid-area: 1/1;
style="grid-area: 1/1;
margin-left: -24px;
margin-right: -24px">

<v-card color="transparent" elevation=0 >
<v-card-text width="100%">
<div class="white--text">
Expand Down

0 comments on commit 3ced249

Please sign in to comment.