Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update crypto payments #199

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Conversation

lukicenturi
Copy link
Contributor

@lukicenturi lukicenturi commented Mar 22, 2024

Closes #201

Checklist

@lukicenturi lukicenturi requested a review from a team as a code owner March 22, 2024 11:19
@kelsos kelsos self-requested a review March 22, 2024 12:07
@kelsos kelsos force-pushed the update-crypto-payments branch from 8407dce to ad040df Compare March 22, 2024 19:06
@kelsos
Copy link
Member

kelsos commented Mar 22, 2024

There is nothing to be done at the moment as part of this PR but I am keeping it open until we are ready to deploy

@lukicenturi
Copy link
Contributor Author

Added fix for #201

@kelsos kelsos force-pushed the update-crypto-payments branch from 75027f5 to 113b3a9 Compare April 2, 2024 08:50
@lukicenturi lukicenturi force-pushed the update-crypto-payments branch 2 times, most recently from 84f6934 to da27791 Compare April 2, 2024 08:59
@lukicenturi lukicenturi force-pushed the update-crypto-payments branch from da27791 to af2d961 Compare April 2, 2024 08:59
Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

<img
class="w-full h-full"
:class="{ hidden: pending || error }"
:src="`/img/chains/${chain}.svg`"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at some point in the future it would probably help to move them to the backend instead

@kelsos kelsos merged commit af2d961 into rotki:main Apr 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent the user from double clicking the Pay with Metamask button
3 participants