fix: remove prefix ri- for lucide icons

rotki · Nov 21, 2024 · 070fed6 · 070fed6
1 parent fa65d2a
commit 070fed6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/scripts/generate-icons.mjs b/scripts/generate-icons.mjs
@@ -5,7 +5,7 @@ import fs from 'fs-extra';
 import { pascalCase } from 'scule';
 import { XMLParser } from 'fast-xml-parser';
 
-const PREFIX = 'ri-';
+const REMIX_PREFIX = 'ri-';
 const LUCIDE_PREFIX = 'lu-';
 const TARGET = 'src/icons/';
 const CHUNK_SIZE = 500;
@@ -74,7 +74,7 @@ async function getAllSvgDataFromPath(pathDir) {
   }
 
   try {
-    const name = PREFIX + path.basename(pathDir).replace('.svg', '');
+    const name = REMIX_PREFIX + path.basename(pathDir).replace('.svg', '');
     const generatedName = pascalCase(name);
     const svg = await readFile(pathDir, 'utf8');
     const svgPath = getPathFromSvgString(svg);
@@ -110,7 +110,7 @@ async function getLucideSvgDataFromPath(pathDir) {
 
   try {
     const filePath = path.basename(pathDir).replace('.js', '');
-    const name = PREFIX + LUCIDE_PREFIX + filePath;
+    const name = LUCIDE_PREFIX + filePath;
     const generatedName = pascalCase(name);
     const iconModule = await import(`${pathDir}`);
     const components = iconModule.default[2];

diff --git a/src/components/icons/RuiIcon.vue b/src/components/icons/RuiIcon.vue
@@ -19,21 +19,22 @@ const props = withDefaults(defineProps<Props>(), {
 
 const { registeredIcons } = useIcons();
 
+const isLucide = computed(() => props.name.startsWith('lu-'));
+
 const components: ComputedRef<[string, Record<string, string>][] | undefined> = computed(() => {
   const name = props.name;
   if (!isRuiIcon(name)) {
     console.warn(`icon ${name} must be a valid RuiIcon`);
   }
-  const iconName = `ri-${name}`;
+  const prefix = get(isLucide) ? '' : 'ri-';
+  const iconName = `${prefix}${name}`;
   const found = registeredIcons[iconName];
 
   if (!found) {
     console.error(`Icons "${name}" not found. Make sure that you have register the icon when installing the RuiPlugin`);
   }
   return found;
 });
-
-const isLucide = computed(() => props.name.startsWith('lu-'));
 </script>
 
 <template>