-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add expandable table #151
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
==========================================
+ Coverage 58.25% 58.39% +0.13%
==========================================
Files 75 76 +1
Lines 12541 12760 +219
Branches 362 386 +24
==========================================
+ Hits 7306 7451 +145
- Misses 5235 5309 +74 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So small comment
src/components/tables/DataTable.vue
Outdated
} | ||
|
||
defineOptions({ | ||
name: 'RuiDataTable', | ||
name: 'RuiDataTableBase', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we keep the component name to RuiDataTable
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @tewshi thanks
Closes #119