Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add expandable table #151

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Conversation

tewshi
Copy link
Contributor

@tewshi tewshi commented Dec 13, 2023

Closes #119

@tewshi tewshi requested a review from a team as a code owner December 13, 2023 21:57
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

Attention: 106 lines in your changes are missing coverage. Please review.

Comparison is base (a542864) 58.25% compared to head (9250fab) 58.39%.

Files Patch % Lines
src/components/tables/DataTable.stories.ts 0.00% 95 Missing ⚠️
src/components/index.ts 0.00% 6 Missing ⚠️
src/components/tables/DataTable.vue 97.17% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
+ Coverage   58.25%   58.39%   +0.13%     
==========================================
  Files          75       76       +1     
  Lines       12541    12760     +219     
  Branches      362      386      +24     
==========================================
+ Hits         7306     7451     +145     
- Misses       5235     5309      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelsos kelsos self-requested a review December 14, 2023 09:16
Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So small comment

}

defineOptions({
name: 'RuiDataTable',
name: 'RuiDataTableBase',
Copy link
Member

@kelsos kelsos Dec 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we keep the component name to RuiDataTable?

Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @tewshi thanks

@kelsos kelsos merged commit d3482dd into rotki:main Dec 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table: Add support for expandable sub-tables
3 participants