Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce defaults for the DataTable #155

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Introduce defaults for the DataTable #155

merged 2 commits into from
Dec 19, 2023

Conversation

kelsos
Copy link
Member

@kelsos kelsos commented Dec 19, 2023

Closes #(issue_number)

@codecov-commenter
Copy link

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (6ceb49e) 58.83% compared to head (e10c358) 58.79%.

Files Patch % Lines
src/index.ts 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   58.83%   58.79%   -0.05%     
==========================================
  Files          77       77              
  Lines       13046    13055       +9     
  Branches      413      413              
==========================================
  Hits         7676     7676              
- Misses       5370     5379       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelsos kelsos changed the title refactor!: change library how initialization happens Introduce defaults for the DataTable Dec 19, 2023
@kelsos kelsos marked this pull request as ready for review December 19, 2023 15:50
@kelsos kelsos requested a review from a team as a code owner December 19, 2023 15:50
Copy link
Contributor

@tewshi tewshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kelsos kelsos merged commit 1da38ad into rotki:main Dec 19, 2023
4 checks passed
@kelsos kelsos deleted the dtb branch December 19, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants