Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Stepper): add loading prop & automatic render for non-custom stepper #166

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

lukicenturi
Copy link
Contributor

No description provided.

@lukicenturi lukicenturi requested a review from a team as a code owner January 2, 2024 10:39
@codecov-commenter
Copy link

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (fd9974a) 60.85% compared to head (ad79e36) 60.80%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/components/steppers/Stepper.stories.ts 0.00% 11 Missing ⚠️
src/components/steppers/Stepper.vue 74.07% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   60.85%   60.80%   -0.05%     
==========================================
  Files          78       78              
  Lines       13142    13184      +42     
  Branches      436      437       +1     
==========================================
+ Hits         7998     8017      +19     
- Misses       5144     5167      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kelsos kelsos merged commit 55307cd into rotki:main Jan 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants