Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move opensuse-leap-15.4 to eol directory #1464

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

xsuchy
Copy link
Member

@xsuchy xsuchy commented Sep 25, 2024

Leap 15.4 EOLed at 07 Dec 2023 according to https://endoflife.date/opensuse

@xsuchy
Copy link
Member Author

xsuchy commented Sep 25, 2024

Seems that regexp for towncrier snippets does not like dots in filename. Should I fix the name or can we ignore it?

@praiskup
Copy link
Member

Should I fix the name or can we ignore it?

I think yes. Reported here: sanitizers/chronographer-github-app#44

@webknjaz
Copy link
Contributor

@xsuchy I haven't checked your towncrier use yet, but it's not just the bot, the underlying tool itself parses the fragments similarly since period-delimited components have defined semantics, unless the fragment is orphaned. My immediate instinct would be fixing the file name.

@xsuchy
Copy link
Member Author

xsuchy commented Sep 25, 2024

@webknjaz I will fix the filename. That is not a problem. But I normally executed towncrier create leap-15.4.config because that seemed natural in this context and towncrier allowed it while the bot later complained.

@xsuchy
Copy link
Member Author

xsuchy commented Sep 25, 2024

File renamed.

@webknjaz
Copy link
Contributor

The first part leap-15 is an issue number in Towncrier. You just happen not to render it. Then, there's 4 which is used for sorting if there's several fragments with that issue number that you don't want ordered randomly. And only after that, there's the category.

Have you tried towncrier check on that fragment? I think it might be a bug on their side with insufficient validation.

The bot fails because it expects the identifier to be a number. The traditional use is putting an issue or a PR ID there, which is the common pattern the bot facilitates originally. I'll need to think if that could be improved.

@webknjaz
Copy link
Contributor

Oh, wait, the number comes after the category. So towncrier will thing that 4 is the category. Try running towncrier build --draft with this fragment. I'm pretty sure it'll either not show up at all or traceback somewhere..

@praiskup
Copy link
Member

We are using a custom template:

template = "releng/release-notes-next/template.jinja"

And the overall use of towncrier is non-standard (the tool doesn't seem to ready to handle monorepos, and we should somehow standardize our release policies for release notes).

The commit looks good, merging! Thank you.

@praiskup praiskup merged commit 2e20bae into rpm-software-management:main Sep 26, 2024
20 of 21 checks passed
@webknjaz
Copy link
Contributor

@praiskup yeah, I've found it already. For monorepos, you could have multiple configs and run towncrier once per each subproject, making multiple change log files that you'd then merge in post-processing, I suppose. You can also have multiple configs for different audiences in the same project, a-la scriv, by calling towncrier differently. If you can outline the needs, I can look into it more in-depth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants