Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the dnf -> dnf4 alias #1476

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Fix the dnf -> dnf4 alias #1476

merged 4 commits into from
Sep 30, 2024

Commits on Sep 30, 2024

  1. package_manager: fix the DNF4 fallback for --no-bootstrap-chroot 

    When package_manager = dnf, 'dnf4' is to be selected and used when
bootstrap chroot is disabled.

This was not detected by test-suite; my bet is that we do tests with
testConfig=fedora-40-x86_64 which is already dnf5 and we have dnf5
installed on the testing machines.  I'm trying to modify one test-case
to test DNF4 chroot explicitly.

Fixes: rpm-software-management#1475
    @praiskup
    praiskup committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    85ebeeb View commit details
    Browse the repository at this point in the history

  2. package_manager: drop a no-op call

    @praiskup
    praiskup committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    6daf6f4 View commit details
    Browse the repository at this point in the history

  3. package_manager: make it obvious that some methods are internal

    @praiskup
    praiskup committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b8b67c7 View commit details
    Browse the repository at this point in the history

  4. package_manager: fix linter issues 

    The rename of methods makes linter thing these are new issues:

- Ignore the f"" warning, as f-string is not optimal for this use-case.
- Use RuntimeError instead of the generic Exception.  It is still too
  generic and mock prints stack trace if it happens, but
  package_manager.py probably deserves it's own exception (rpm-software-management#1477).
    @praiskup
    praiskup committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1fed15e View commit details
    Browse the repository at this point in the history