Add unit tests for perl.prov #5
Open
+384
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlpunk
force-pushed
the
unit-tests
branch
3 times, most recently
from
6318ede to
809c831
Compare
This adds unit tests to achieve 100% coverage for perl.prov. I didn't want to introduce any changes in perl.prov at this point so I added some todos: * The code doesn't work on perl 5.8 anymore because it doesn't have version.pm. I think it can be fixed by moving the version->parse thing into the branch where the actual commandline option is used. Not sure which old perl versions we have to support, but 5.8 should be easy to support, and it might be possible someone would want to run the latest rpm on a machine with perl 5.8 * Bare <<EOM tags are not supported yet * Versions with a single digit aren't supported (`\d+[._0-9]+`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds unit tests to achieve 100% coverage for perl.prov.
I didn't want to introduce any changes in perl.prov at this point so
I added some todos:
I think it can be fixed by moving the version->parse thing into the branch
where the actual commandline option is used. Not sure which old perl
versions we have to support, but 5.8 should be easy to support, and
it might be possible someone would want to run the latest rpm on a machine
with perl 5.8
\d+[._0-9]+)It runs the unit tests on all perl versions, and runs the coverage in an extra job and checks for 100%.
I had to mark one line as uncoverable.