Skip to content

Commit

Permalink
Merge pull request #37 from rqlite/topic/backup-endpoint-fix
Browse files Browse the repository at this point in the history
Preserve backward compatibility for backup endpoint
  • Loading branch information
jtackaberry authored Nov 14, 2024
2 parents e63291d + 83d9e50 commit 0425089
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions charts/rqlite/templates/secret.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,15 @@ user-suppplied list below
"path" (dig "backup" "storage" "path" nil $config)
"force_path_style" (dig "backup" "storage" "forcePathStyle" false $config)
}}
{{- if and $backupStorage.endpoint (not (contains "://" $backupStorage.endpoint)) }}
{{/*
As part of the upgrade to AWS SDK v2 in rqlite v8.29.3, the endpoint now must be
specified as a URI rather than a straight FQDN. This is a breaking change, but rather
than bumping the major version of the chart to reflect the incompatibility, we just
prepend "https://" to the endpoint if it doesn't already contain a scheme.
*/}}
{{- $_ := set $backupStorage "endpoint" (printf "https://%s" $backupStorage.endpoint) }}
{{- end }}
{{- $backup := dict }}
{{- $restore := dict }}
{{- if dig "backup" "autoBackup" "enabled" false $config }}
Expand Down

0 comments on commit 0425089

Please sign in to comment.