Skip to content

Commit

Permalink
Code review comment responses
Browse files Browse the repository at this point in the history
Must have had a brain cramp before checking this stuff in.
Had left changes in made during testing that
  • Loading branch information
freemansoft committed Jul 24, 2023
1 parent b5d4ddd commit 272c42a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
3 changes: 2 additions & 1 deletion packages/riverpod_graph/lib/src/analyze.dart
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ Future<void> analyze(
bool verifyRootDirectoryExists(String rootDirectory) {
if (!Directory(rootDirectory).existsSync()) {
throw FileSystemException(
'Requested scanning target directory does not exist $rootDirectory');
'Requested scanning target directory does not exist $rootDirectory',
);
}
return true;
}
Expand Down
7 changes: 2 additions & 5 deletions packages/riverpod_graph/test/analyze_test.dart
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// ignore_for_file: avoid_types_on_closure_parameters

import 'dart:io';

import 'package:riverpod_graph/src/analyze.dart';
Expand All @@ -9,9 +7,8 @@ import 'package:test/test.dart';
void main() {
group('flutter graph analyzer tests', () {
test('throw exception if analysis target directory does not exist', () {
// expect(() => verifyRootDirectoryExists('dogfood'),
// throwsA(isA<FileSystemException>())
// );
expect(() => verifyRootDirectoryExists('dogfood'),
throwsA(isA<FileSystemException>()));
});

test('returns true if analysis target directory does exist', () {
Expand Down

0 comments on commit 272c42a

Please sign in to comment.