Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix family.overrideWith cast error and include family arguments in the ref #2852

Merged
merged 11 commits into from
Aug 28, 2023

Conversation

rrousselGit
Copy link
Owner

fixes #2832
fixes #2851

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #2852 (1446a6a) into master (4461140) will decrease coverage by 4.76%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##            master    #2852      +/-   ##
===========================================
- Coverage   100.00%   95.24%   -4.76%     
===========================================
  Files            3       53      +50     
  Lines           74     2249    +2175     
===========================================
+ Hits            74     2142    +2068     
- Misses           0      107     +107     
Files Changed Coverage Δ
.../riverpod/lib/src/async_notifier/auto_dispose.dart 100.00% <100.00%> (ø)
...od/lib/src/async_notifier/auto_dispose_family.dart 86.36% <100.00%> (ø)
packages/riverpod/lib/src/async_notifier/base.dart 100.00% <100.00%> (ø)
...ckages/riverpod/lib/src/async_notifier/family.dart 85.71% <100.00%> (ø)
...riverpod/lib/src/future_provider/auto_dispose.dart 92.30% <100.00%> (ø)
...ackages/riverpod/lib/src/future_provider/base.dart 93.75% <100.00%> (ø)
...ckages/riverpod/lib/src/notifier/auto_dispose.dart 100.00% <100.00%> (ø)
...riverpod/lib/src/notifier/auto_dispose_family.dart 76.19% <100.00%> (ø)
packages/riverpod/lib/src/notifier/base.dart 100.00% <100.00%> (ø)
packages/riverpod/lib/src/notifier/family.dart 73.91% <100.00%> (ø)
... and 8 more

... and 32 files with indirect coverage changes

@rrousselGit rrousselGit merged commit 41f020d into master Aug 28, 2023
41 of 42 checks passed
@rrousselGit rrousselGit deleted the fix-family-notifier-override branch August 28, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant