Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vsync race condition on providerscope unmount #3072

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Conversation

rrousselGit
Copy link
Owner

fixes #2022

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #3072 (0dcdd4c) into master (66e7777) will decrease coverage by 0.21%.
The diff coverage is 28.57%.

❗ Current head 0dcdd4c differs from pull request most recent head 58032a1. Consider uploading reports for the commit 58032a1 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3072      +/-   ##
==========================================
- Coverage   95.30%   95.10%   -0.21%     
==========================================
  Files          53       53              
  Lines        2281     2288       +7     
==========================================
+ Hits         2174     2176       +2     
- Misses        107      112       +5     
Files Coverage Δ
packages/riverpod/lib/src/framework/scheduler.dart 87.23% <28.57%> (-10.27%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setState() or markNeedsBuild() called during build errors after recreating container
1 participant