Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: invalid use of Uri.https #3677

Merged
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

---

A reactive caching and data-binding framework. https://riverpod.dev
A reactive caching and data-binding framework. https://riverpod.dev
Riverpod makes working with asynchronous code a breeze by:

- handling errors/loading states by default. No need to manually catch errors
Expand All @@ -37,7 +37,7 @@ Riverpod makes working with asynchronous code a breeze by:

Welcome to [Riverpod] (anagram of [Provider])!

For learning how to use [Riverpod], see its documentation:
For learning how to use [Riverpod], see its documentation:
\>\>\> https://riverpod.dev <<<

Long story short:
Expand All @@ -48,7 +48,7 @@ Long story short:
@riverpod
Future<String> boredSuggestion(BoredSuggestionRef ref) async {
final response = await http.get(
Uri.https('https://boredapi.com/api/activity'),
Uri.parse('https://boredapi.com/api/activity'),
Luckey-Elijah marked this conversation as resolved.
Show resolved Hide resolved
);
final json = jsonDecode(response.body);
return json['activity']! as String;
Expand Down
4 changes: 4 additions & 0 deletions packages/riverpod/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.5.2

Luckey-Elijah marked this conversation as resolved.
Show resolved Hide resolved
- Fix documentation invalid use of `Uri.https` in README and website snippet. (thanks to @Luckey-Elijah)

## 2.5.1 - 2024-03-10

- Improved `Provider(dependencies: [...])` documentation.
Expand Down
2 changes: 1 addition & 1 deletion website/static/snippets/create.dart
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ part 'create.g.dart';
@riverpod
Future<String> boredSuggestion(BoredSuggestionRef ref) async {
final response = await http.get(
Uri.https('https://boredapi.com/api/activity'),
Uri.parse('https://boredapi.com/api/activity'),
);
final json = jsonDecode(response.body) as Map;
return json['activity']! as String;
Expand Down
Loading