Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: neg steps of {Enum,String}.slice/2 are deprecated in Elixir 1.16 #1099

Closed
wants to merge 1 commit into from
Closed

fix: neg steps of {Enum,String}.slice/2 are deprecated in Elixir 1.16 #1099

wants to merge 1 commit into from

Conversation

fishtreesugar
Copy link

As mentioned in Elixir 1.16's changelog:

[Enum] Deprecate passing a range with negative step on Enum.slice/2, give first..last//1 instead
[String] Deprecate passing a range with negative step on String.slice/2, give first..last//1 instead

@rrrene
Copy link
Owner

rrrene commented Dec 28, 2023

Hi.

Did this give you a warning with Elixir 1.16? I can't seem to reproduce a warning.

@fishtreesugar
Copy link
Author

Yes, it shown when running w/ Elixir 1.16

@rrrene
Copy link
Owner

rrrene commented Dec 28, 2023

Strange. We tried to avoid this scenario. 😰

What system are you running this on? And which versions of OTP/Credo?

@rrrene
Copy link
Owner

rrrene commented Jan 30, 2024

Hi, since I was not able to reproduce this with any of my friends or in GitHub actions (where we now have a Mac runner because of this issue 👍 ), I am closing this.

If anyone has any issues with this in the future, please comment and/or re-open! 🙏

@rrrene rrrene closed this Jan 30, 2024
@fishtreesugar fishtreesugar deleted the fix-slice-neg branch January 30, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants