Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updating max pegout to 10 #748

Merged
merged 2 commits into from
Jun 28, 2024
Merged

refactor: updating max pegout to 10 #748

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eee8cd
refactor: updating max value for pegout to 10
annipi Jun 24, 2024
b1e18a8
refactor: update twowp_api_max_amount_allowed_in_satoshi environment …
annipi Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .env.local.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ VUE_APP_RSK_EXPLORER=https://explorer.testnet.rsk.co/

# replace VALUE with the clarity id for the environment the app is being deployed to.
VUE_APP_PEGOUT_MIN_AMOUNT_ALLOWED_IN_RBTC=0.005
VUE_APP_PEGOUT_MAX_AMOUNT_ALLOWED_IN_RBTC=1
VUE_APP_PEGOUT_MAX_AMOUNT_ALLOWED_IN_RBTC=10
#VUE_APP_CLARITY_ID=VALUE

## fee boundaries
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy_MainNet_UI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
VUE_APP_WALLET_ADDRESSES_HARD_STOP=100
VUE_APP_WALLET_ADDRESS_PER_CALL=20
VUE_APP_PEGOUT_MIN_AMOUNT_ALLOWED_IN_RBTC=0.004
VUE_APP_PEGOUT_MAX_AMOUNT_ALLOWED_IN_RBTC=1
VUE_APP_PEGOUT_MAX_AMOUNT_ALLOWED_IN_RBTC=10
npm run-script build

- name: Configure AWS credentials
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy_TestNet_UI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
VUE_APP_WALLET_ADDRESSES_HARD_STOP=100
VUE_APP_WALLET_ADDRESS_PER_CALL=20
VUE_APP_PEGOUT_MIN_AMOUNT_ALLOWED_IN_RBTC=0.004
VUE_APP_PEGOUT_MAX_AMOUNT_ALLOWED_IN_RBTC=1
VUE_APP_PEGOUT_MAX_AMOUNT_ALLOWED_IN_RBTC=10
npm run-script build

- name: Configure AWS credentials
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy_staging_MainNet_UI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
VUE_APP_WALLET_ADDRESSES_HARD_STOP=100
VUE_APP_WALLET_ADDRESS_PER_CALL=20
VUE_APP_PEGOUT_MIN_AMOUNT_ALLOWED_IN_RBTC=0.004
VUE_APP_PEGOUT_MAX_AMOUNT_ALLOWED_IN_RBTC=1
VUE_APP_PEGOUT_MAX_AMOUNT_ALLOWED_IN_RBTC=10
npm run-script build

- name: Configure AWS credentials
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy_staging_TestNet_UI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v3
with:
ref: qa
ref: qa

- name: Setup NodeJS
uses: actions/setup-node@v3
Expand All @@ -40,7 +40,7 @@ jobs:
VUE_APP_WALLET_ADDRESSES_HARD_STOP=100
VUE_APP_WALLET_ADDRESS_PER_CALL=20
VUE_APP_PEGOUT_MIN_AMOUNT_ALLOWED_IN_RBTC=0.004
VUE_APP_PEGOUT_MAX_AMOUNT_ALLOWED_IN_RBTC=1
VUE_APP_PEGOUT_MAX_AMOUNT_ALLOWED_IN_RBTC=10
VUE_APP_LBC_ADDRESS='0xc2A630c053D12D63d32b025082f6Ba268db18300'
npm run-script build

Expand Down
40 changes: 20 additions & 20 deletions ENV_VARIABLES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,25 @@
This table was created to guide and centralize the **environment variables** necessary for correct execution.
The value of these variables are used in **environment-variables.ts** file.

|NAME | DEV VALUE | DETAILS |
|--------------------------------------------|-------------|-----------------------------------------------------------------------------------------------------------|
|VUE_APP_COIN | `test / main` | The network that will be used for the bitcoin library. Accepted values are `test` or `main` |
|VUE_APP_MANIFEST_EMAIL | | |
|VUE_APP_MANIFEST_APP_URL | | Trezor connect Manifest is described [here](https://github.com/trezor/connect/blob/develop/docs/index.md) |
|VUE_APP_API_BASE_URL | | URL of the API (2wp-api) which is the BackEnd |
|VUE_APP_RSK_NODE_HOST | | RSK node URL to verify RSK data (e.g. POWpeg address |
|VUE_APP_CLARITY_ID | | A Clarity ID is uniquely generated identification for app usage metrics |
|VUE_APP_RSK_EXPLORER | | RSK EXPLORER URL used to verify the transaction status |
|VUE_APP_WALLET_ADDRESSES_HARD_STOP | `100` | Maximum number of addresses derived from wallet |
|VUE_APP_WALLET_ADDRESS_PER_CALL | `5` | Number of addresses obtained per derivation call |
|VUE_APP_PEGOUT_MIN_AMOUNT_ALLOWED_IN_RBTC | `0.004` | 0,004 Minimum allowed value for a PEGOUT transaction |
|VUE_APP_PEGOUT_MAX_AMOUNT_ALLOWED_IN_RBTC | `1` | 1 Maximum allowed value for a PEGOUT transaction |
|VUE_APP_BURN_DUST_VALUE | `30000` | Max value to burn in the tx fee |
|VUE_APP_MIN_FEE_SAT_PER_BYTE_FAST | `8` | Min fee rate (sats/byte) required to broadcast the transaction |
|VUE_APP_MIN_FEE_SAT_PER_BYTE_AVG | `4` | Min fee rate (sats/byte) required to broadcast the transaction |
|VUE_APP_MIN_FEE_SAT_PER_BYTE_SLOW | `1` | Min fee rate (sats/byte) required to broadcast the transaction |
|VUE_APP_LBC_ADDRESS | `0xc2A630c053D12D63d32b025082f6Ba268db18300` | Liquidity bridge contract address on the flyover protocol |
|VUE_APP_DEBUG_MODE | `false` | enable developer messages for debuging |
|NAME | DEV VALUE | DETAILS |
|--------------------------------------------|----------------------------------------------|-----------------------------------------------------------------------------------------------------------|
|VUE_APP_COIN | `test / main` | The network that will be used for the bitcoin library. Accepted values are `test` or `main` |
|VUE_APP_MANIFEST_EMAIL | | |
|VUE_APP_MANIFEST_APP_URL | | Trezor connect Manifest is described [here](https://github.com/trezor/connect/blob/develop/docs/index.md) |
|VUE_APP_API_BASE_URL | | URL of the API (2wp-api) which is the BackEnd |
|VUE_APP_RSK_NODE_HOST | | RSK node URL to verify RSK data (e.g. POWpeg address |
|VUE_APP_CLARITY_ID | | A Clarity ID is uniquely generated identification for app usage metrics |
|VUE_APP_RSK_EXPLORER | | RSK EXPLORER URL used to verify the transaction status |
|VUE_APP_WALLET_ADDRESSES_HARD_STOP | `100` | Maximum number of addresses derived from wallet |
|VUE_APP_WALLET_ADDRESS_PER_CALL | `5` | Number of addresses obtained per derivation call |
|VUE_APP_PEGOUT_MIN_AMOUNT_ALLOWED_IN_RBTC | `0.004` | 0,004 Minimum allowed value for a PEGOUT transaction |
|VUE_APP_PEGOUT_MAX_AMOUNT_ALLOWED_IN_RBTC | `10` | 10 Maximum allowed value for a PEGOUT transaction |
|VUE_APP_BURN_DUST_VALUE | `30000` | Max value to burn in the tx fee |
|VUE_APP_MIN_FEE_SAT_PER_BYTE_FAST | `8` | Min fee rate (sats/byte) required to broadcast the transaction |
|VUE_APP_MIN_FEE_SAT_PER_BYTE_AVG | `4` | Min fee rate (sats/byte) required to broadcast the transaction |
|VUE_APP_MIN_FEE_SAT_PER_BYTE_SLOW | `1` | Min fee rate (sats/byte) required to broadcast the transaction |
|VUE_APP_LBC_ADDRESS | `0xc2A630c053D12D63d32b025082f6Ba268db18300` | Liquidity bridge contract address on the flyover protocol |
|VUE_APP_DEBUG_MODE | `false` | enable developer messages for debuging |

## Example for .env.local.test file

Expand All @@ -36,7 +36,7 @@ VUE_APP_RSK_EXPLORER=https://explorer.testnet.rootstock.io/
VUE_APP_WALLET_ADDRESSES_HARD_STOP=100
VUE_APP_WALLET_ADDRESS_PER_CALL=5
VUE_APP_PEGOUT_MIN_AMOUNT_ALLOWED_IN_RBTC=0.005
VUE_APP_PEGOUT_MAX_AMOUNT_ALLOWED_IN_RBTC=1
VUE_APP_PEGOUT_MAX_AMOUNT_ALLOWED_IN_RBTC=10
VUE_APP_BURN_DUST_VALUE=30000
VUE_APP_MIN_FEE_SAT_PER_BYTE_FAST=8
VUE_APP_MIN_FEE_SAT_PER_BYTE_AVG=4
Expand Down
2 changes: 1 addition & 1 deletion src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const defaultEnvironmentVariables = {
vueAppHotjarId: '',
vueAppClarityId: '',
pegoutMinValue: 0.005,
pegoutMaxValue: 1,
pegoutMaxValue: 10,
minFeeSatPerByte: {
fast: 8,
average: 4,
Expand Down
Loading