Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean wallet connections #935

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Clean wallet connections #935

merged 2 commits into from
Nov 29, 2024

Conversation

ronaldsg20
Copy link
Member

@ronaldsg20 ronaldsg20 commented Nov 25, 2024 •
edited by annipi
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@ronaldsg20 ronaldsg20 marked this pull request as draft November 25, 2024 16:04
@annipi annipi force-pushed the feature/clean-wallet-connection branch 2 times, most recently from c492c9e to ea43d3d Compare November 26, 2024 06:04
@annipi annipi marked this pull request as ready for review November 26, 2024 14:57
@annipi annipi force-pushed the feature/clean-wallet-connection branch from ea43d3d to 5e8f84f Compare November 26, 2024 16:15
@annipi annipi force-pushed the feature/clean-wallet-connection branch 2 times, most recently from 1ce763c to 55db6f1 Compare November 28, 2024 15:25
alexjavabraz
alexjavabraz approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@alexjavabraz alexjavabraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annipi annipi force-pushed the feature/clean-wallet-connection branch from 55db6f1 to c22d2c2 Compare November 28, 2024 17:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

leoiovlabs
leoiovlabs approved these changes Nov 29, 2024
View reviewed changes
Copy link

@leoiovlabs leoiovlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexjavabraz alexjavabraz merged commit 5cdf06d into feature/2.3 Nov 29, 2024
3 of 4 checks passed
@alexjavabraz alexjavabraz deleted the feature/clean-wallet-connection branch November 29, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annipi annipi annipi left review comments

@lserra-iov lserra-iov lserra-iov approved these changes

@leoiovlabs leoiovlabs leoiovlabs approved these changes

@alexjavabraz alexjavabraz alexjavabraz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ronaldsg20 @annipi @alexjavabraz @leoiovlabs @lserra-iov