Adding Rootstock Integration Tests workflow to Powpeg node repo

[rmoreliovlabs]

Adding of Rootstock Integration Tests Workflow for PowPeg

This GitHub Actions workflow is designed to automate the execution of Rootstock Integration Tests for the PowPeg Node repository. The primary goal is to ensure that integration tests are run manually or automatically for opened pull requests against the master branch or any *-rc branches, as well as for direct pushes to these branches. There's a similar pr for this feature in the RSKJ repo, check here.

Implementation Details

Triggers:

• Pull Requests: The workflow triggers on pull requests opened or reopened against any branch, specifically targeting master and *-rc branches.
• Push Events: The workflow triggers on pushes to master and *-rc branches.
• Manual Trigger: The workflow can be manually triggered using the workflow_dispatch event, which allows for additional customization via inputs.

How to Trigger the Workflow

Automatically:

• Pull Requests: The workflow will automatically trigger when a pull request is opened or reopened against the master or *-rc branches.
• Pushes: The workflow will automatically trigger on pushes to the master and *-rc branches.

Manually:

Workflow Dispatch: You can manually trigger the workflow using the workflow_dispatch event. To do this, follow these steps:

• Navigate to the Actions tab in your GitHub repository.
• Select the Rootstock Integration Tests workflow from the list of workflows.
• Click on the Run workflow button.
• Choose the branch from which you want to run the workflow using the "Use workflow from branch" dropdown menu. This allows you to select the branch (e.g., feature-branch) that will be used for the POWPEG_BRANCH value.
• Enter the desired input parameters (if any) or leave them as their default values.

Inputs for Manual Trigger:

• rit-branch: The branch for Rootstock Integration Tests.
  Default: main
• rskj-branch: The branch for RSKJ.
  Default: master

To manually trigger the workflow using workflow_dispatch, the workflow file must be present in the master branch. That's we can't manually test this workflow until it's merged into master. For more info, check here and here.

Motivation and Context

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• Tests for the changes have been added (for bug fixes / features)
• Requires Activation Code (Hard Fork)

• Other information:

[fmacleal]

Great job, I think we are almost there and there a few things to change and we are done. 😃

[fmacleal]

Good job! I just have a question regarding your last change, but it doesn't prevent the approval. I think this way it will fill the initial requirements we have for this pipeline, we can always change if needed. :)

[bernacodesido]

LGTM

[marcos-iov]

Is there a way to somehow re-use the default branch values that are defined above?

[fmacleal]

Hello, yes, it seems possible. Do you think it's better to re-use it? Nevertheless, to change these default values we would have to change the worfklow yaml anyway.

We would have to do something like this:

Suggested change

	RIT_BRANCH="${{ github.event.inputs.rit-branch || 'main' }}"
	RSKJ_BRANCH="${{ github.event.inputs.rskj-branch || 'master' }}"
	RIT_BRANCH="${{ github.event.inputs.rit-branch || github.event.inputs['rit-branch'].default }}"
	RSKJ_BRANCH="${{ github.event.inputs.rskj-branch || github.event.inputs['rskj-branch'].default }}"

[fmacleal]

Ops, the suggestion failed. Probably because the inputs are define only if the pipeline is triggered via workflow_dispatch. This logic wouldn't work for the commits in PR.

Let's let as it was? Otherwise we will need an even bigger if like:

 RSKJ_BRANCH="${{ github.event.inputs.rskj-branch || github.event.inputs['rskj-branch'].default || 'main' }}"

[marcos-iov]

No big deal, I wouldn't expect the default branches to change anytime soon. Just the good practice of avoid repetition (DRY). But in this case I'd go with the simplest solution

[sonarqubecloud]

Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.5% Coverage on New Code
2.4% Duplication on New Code

See analysis details on SonarCloud

[marcos-iov]

pipeline:run