Add support to 32-byte chainwork to ThinConverter class #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
julia-zack
reviewed
Nov 28, 2024
|
|
||
| class ThinConverterTest { | ||
|
|
||
| private static final BigInteger NEGATIVE_CHAIN_WORK = BigInteger.valueOf(-1); | ||
| private static final BigInteger EIGHT_BYTES_WORK_V1 = new BigInteger("ffffffffffffffff", 16); // 8 bytes |
There was a problem hiding this comment.
why eight? i'd just say something like BELOW_MAX_WORK_V1. wdyt?
julia-zack
reviewed
Nov 28, 2024
|
|
||
| private static final ECKey userKey = ECKey.fromPrivate(BigInteger.valueOf(100)); | ||
|
|
||
| public static Stream<Arguments> validChainWorkArgsProvider() { |
There was a problem hiding this comment.
Suggested change
| public static Stream<Arguments> validChainWorkArgsProvider() { | |
| public static Stream<Arguments> validChainWorkV2ArgsProvider() { |
There was a problem hiding this comment.
No. This includes both formats of chainwork.
There was a problem hiding this comment.
how is the too large work v1 valid in v1?
julia-zack
reviewed
Nov 28, 2024
| ); | ||
| } | ||
|
|
||
| public static Stream<Arguments> invalidChainWorkArgsProvider() { |
There was a problem hiding this comment.
Suggested change
| public static Stream<Arguments> invalidChainWorkArgsProvider() { | |
| public static Stream<Arguments> invalidChainWorkV2ArgsProvider() { |
same here
There was a problem hiding this comment.
Same here. Including both format
julia-zack
reviewed
Nov 28, 2024
julia-zack
approved these changes
Nov 29, 2024
- Renamed EIGHT_BYTES_WORK_V1 constant to BELOW_MAX_WORK_V1
nathanieliov
force-pushed
the
use-serialize-and-deserialize-V2
branch
from
8dd18fd to
877b3ce
Compare
|
Closing this PR in benefit of #359 using the same branch name as rskj branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support to 32-byte chainwork to ThinConverter class
How Has This Been Tested?
Unit tests
Types of changes
Checklist: