Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coinbase refactor #360

Merged
merged 6 commits into from
Dec 5, 2024
Merged

Coinbase refactor #360

merged 6 commits into from
Dec 5, 2024

Conversation

marcos-iov
Copy link
Collaborator

@marcos-iov marcos-iov commented Dec 5, 2024

Relates to rsksmart/rskj#2876

Description

  • Use new method to find witness commitment in coinbase transactions
  • Add extra logs and tests

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

rskj:coinbase-refactor

@marcos-iov marcos-iov requested a review from a team as a code owner December 5, 2024 14:53
Copy link

github-actions bot commented Dec 5, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@aeidelman aeidelman merged commit dd4a20f into master Dec 5, 2024
12 checks passed
@aeidelman aeidelman deleted the coinbase-refactor branch December 5, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants